Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ethernet broadcast for all systems with MMIO access to all chips #486

Open
aliuTT opened this issue Jan 27, 2025 · 1 comment
Open

Disable ethernet broadcast for all systems with MMIO access to all chips #486

aliuTT opened this issue Jan 27, 2025 · 1 comment

Comments

@aliuTT
Copy link
Collaborator

aliuTT commented Jan 27, 2025

No description provided.

@aliuTT
Copy link
Collaborator Author

aliuTT commented Jan 27, 2025 

- // MT: Initial BH - Disable dependency to ethernet firmware
-    if (arch_name == tt::ARCH::BLACKHOLE) {
+    // Disable dependency to ethernet firmware for all BH devices and WH devices with all chips having MMIO (e.g. UBB Galaxy)
+    if (cluster_desc->get_chips_with_mmio().size() == cluster_desc->get_all_chips().size()) {

aliuTT added a commit that referenced this issue Jan 28, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
d93ad5b 
…ips (#486)
@aliuTT aliuTT mentioned this issue Jan 28, 2025
Merged
aliuTT added a commit that referenced this issue Jan 28, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
adcb426 
…ips (#486)
aliuTT added a commit that referenced this issue Jan 28, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
3a6b19e 
…ips (#486)
aliuTT added a commit that referenced this issue Jan 28, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
6e525c7 
…ips (#486)
aliuTT added a commit that referenced this issue Jan 28, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
dadf1bc 
…ips (#486)
aliuTT added a commit that referenced this issue Jan 29, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
a0b9c33 
…ips (#486)
aliuTT added a commit that referenced this issue Feb 3, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
8dfc031 
…ips (#486)
aliuTT added a commit that referenced this issue Feb 3, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
132d11e 
…ips (#486)
aliuTT added a commit that referenced this issue Feb 3, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
68a624e 
…ips (#486)
aliuTT added a commit that referenced this issue Feb 3, 2025
@aliuTT
Disable ethernet broadcast for all systems with MMIO access to all ch…
b24a0c6 
…ips (#487)

### Issue
[(Link to Github
issue(s))](#486)

### Description
Ethernet broadcast was getting used for all-mmio system like UBB. This
is causing race conditions when opening and closing drivers, since the
reset signals are getting broadcasted through ethernet FW but the done
check is through MMIO.

### List of the changes
Disable ethernet broadcast for systems with num chips equal to num mmio
chips.

### Testing
Tests in Metal on UBB Galaxy

### API Changes
There are no API changes in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aliuTT