-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding ability to reload system device and device descriptors and fix…
… flaky test (#2259) ### Ticket Closes #2258 ### Problem description Some people noticed failures of the following Silicon test: test/ttmlir/Silicon/TTNN/n150/Transforms/DecomposeLayouts/decomposing_layouts_from_host.mlir This test utilizes Python script to prepare the mlir for test execution, hence on some dev machines it fails due to different environment configurations. ### What's changed Solved the test flakiness by adding the ability to reload the system and device descriptors in passes: - --ttir-load-system-desc - --ttir-implicit-device Utilized the new capability to fix the flaky test, using the MLIR pass to prepare the MLIR for execution instead of relying on a Python script. New test behavior: - The test has default system and device descriptors present in their MLIR files. - --ttir-load-system-desc reloads a new system descriptor based on machine setup - --ttir-implicit-device reloads a new device descriptor based on a newly loaded system descriptor ### Checklist - [x] New/Existing tests provide coverage for changes
- Loading branch information
1 parent
f15e704
commit b112dba
Showing
5 changed files
with
10 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/ttmlir/Dialect/TTNN/Transforms/DecomposeLayouts/decomposing_layouts_from_host.mlir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 5 additions & 7 deletions
12
test/ttmlir/Silicon/TTNN/n150/Transforms/DecomposeLayouts/decomposing_layouts_from_host.mlir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 0 additions & 131 deletions
131
tools/scripts/extract-and-replace-system-desc-and-device.py
This file was deleted.
Oops, something went wrong.