Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UMD] Remove a couple of leftover usages of old soc descriptor API #18352

Merged
merged 1 commit into from
Feb 26, 2025
+3 −3
Merged

[UMD] Remove a couple of leftover usages of old soc descriptor API #18352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tt_metal/fabric/control_plane.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ void ControlPlane::convert_fabric_routing_table_to_chip_routing_table() {
const auto& physical_chip_id =
this->logical_mesh_chip_id_to_physical_chip_id_mapping_[mesh_id][src_chip_id];
std::uint32_t num_ports_per_chip =
tt::Cluster::instance().get_soc_desc(physical_chip_id).ethernet_cores.size();
tt::Cluster::instance().get_soc_desc(physical_chip_id).get_cores(CoreType::ETH).size();
this->intra_mesh_routing_tables_[mesh_id][src_chip_id].resize(
num_ports_per_chip); // contains more entries than needed, this size is for all eth channels on chip
for (int i = 0; i < num_ports_per_chip; i++) {
Expand Down Expand Up @@ -368,7 +368,7 @@ void ControlPlane::convert_fabric_routing_table_to_chip_routing_table() {
const auto& physical_chip_id =
this->logical_mesh_chip_id_to_physical_chip_id_mapping_[src_mesh_id][src_chip_id];
std::uint32_t num_ports_per_chip =
tt::Cluster::instance().get_soc_desc(physical_chip_id).ethernet_cores.size();
tt::Cluster::instance().get_soc_desc(physical_chip_id).get_cores(CoreType::ETH).size();
this->inter_mesh_routing_tables_[src_mesh_id][src_chip_id].resize(
num_ports_per_chip); // contains more entries than needed
for (int i = 0; i < num_ports_per_chip; i++) {
Expand Down
2 changes: 1 addition & 1 deletion tt_metal/tools/memset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ void memset_dram(std::vector<uint32_t> mem_vec, uint32_t chip_id, uint32_t start
const metal_SocDescriptor& sdesc = tt::Cluster::instance().get_soc_desc(chip_id);
for (uint32_t dram_view = 0; dram_view < sdesc.get_num_dram_views(); dram_view++) {
for (uint32_t dram_src_subchannel_id = 0;
dram_src_subchannel_id < sdesc.dram_cores.at(sdesc.get_channel_for_dram_view(dram_view)).size();
dram_src_subchannel_id < sdesc.get_dram_cores().at(sdesc.get_channel_for_dram_view(dram_view)).size();
dram_src_subchannel_id++) {
tt::Cluster::instance().write_dram_vec(
mem_vec, tt_target_dram{chip_id, dram_view, dram_src_subchannel_id}, start_addr);
Expand Down
Loading