Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UMD] Remove a couple of leftover usages of old soc descriptor API #18352

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Feb 26, 2025

Ticket

Related to #17002

Problem description

A follow up from removing .dram_cores in #17620 and removing eth_cores in #17642

Not sure if I made mistake during merging changes, or if these changes happened in the meantime. With this changes, tt_metal builds with this UMD change which is the ultimate goal: tenstorrent/tt-umd#509

What's changed

  • Changed .dram_cores with .get_dram_cores()
  • Changed .ethernet_cores with .get_cores(CoreType::ETH)

Checklist

All runs on brosko/umd_api_last_changes :

@broskoTT broskoTT merged commit f5978ad into main Feb 26, 2025
254 of 267 checks passed
@broskoTT broskoTT deleted the brosko/umd_api_last_changes branch February 26, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants