Move out halo construction OP/kernel from TMs in to sliding window #18172
+12
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfang-TT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
sminakov-tt,
a team,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT,
llongTT and
nardoTT
as code owners
| const uint16_t my_noc_x, | ||
| const uint16_t my_noc_y, | ||
| uint32_t const in_base_l1_addr, |
There was a problem hiding this comment.
let's avoid changes to code that are not related to move
There was a problem hiding this comment.
In fact, I don't want to change it but the formatter (clang) enforce me to change it otherwise I cannot push the code. Is there any way that I can skip this? If so, I can reverse the code change.
ttnn/cpp/ttnn/operations/sliding_window/halo/device/halo_device_operation.cpp
Outdated
Show resolved
Hide resolved
pavlejosipovic
approved these changes
Feb 24, 2025
zfang-TT
requested review from
patrickroberts,
razorback3 and
dongjin-na
as code owners
zfang-TT
force-pushed
the
zfang/sep_halo
branch
from
ad54f4b to
88c1eb5
Compare
|
@zfang-TT please don't forget to update PR title |
mywoodstock
approved these changes
Feb 25, 2025
mywoodstock
changed the title
zfang-TT
force-pushed
the
zfang/sep_halo
branch
from
88c1eb5 to
26299cd
Compare
ntarafdar
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue.
Problem description
Moving
ttnn/cpp/ttnn/operations/data_movement/untilize_with_halo_v2tottnn/cpp/ttnn/operations/sliding_window/halo/devicesince this is the only place to use halo operator.What's changed
Moving
ttnn/cpp/ttnn/operations/data_movement/untilize_with_halo_v2tottnn/cpp/ttnn/operations/sliding_window/halo/device. Updatettnn/CMakeLists.txt, and relevant files.Checklist