Replacing L1 base address increment instructions with CFGSHIFTMASK #17723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Blackhole has new
CFGSHIFTMASK
that can update addresses for the unpacker instructions inside the mop/replay buffers. If an operation is unpacker bound, then using this instruction should increase performance.What's changed
Replaced L1 base address increment code that uses cfg read/write and tdma gpr operations with the new
CFGSHIFTMASK
instruction in the unpack AB matmul llk api. This replacement saves 6 instructions in the mop replay buffer. No notable performance improvements.Only affects BH and addresses an issue in BH third party repo.
Checklist