#15246: Add sweeps for isclose, isclose sharded, ldexp sharded, log… #17300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjagrujic
requested review from
patrickroberts,
yan-zaretskiy,
xanderchin,
jdesousa-TT and
sjameelTT
as code owners
amalbasaTT
approved these changes
Jan 30, 2025
nemanjagrujic
force-pushed
the
ngrujic/sweep-tests-5
branch
from
13c8ce8 to
64acade
Compare
amalbasaTT
reviewed
Jan 31, 2025
| @@ -306,6 +308,9 @@ on: | |||
| - eltwise.binary.add.add_different_memory_configs | |||
| - eltwise.binary.add.add_forge | |||
| - eltwise.binary.add.add_llama | |||
| - eltwise.binary.add.add_llama | |||
nemanjagrujic
changed the title
…addexp sharded and more ops
nemanjagrujic
force-pushed
the
ngrujic/sweep-tests-5
branch
from
5c3f8af to
1df29db
Compare
jdesousa-TT
approved these changes
Feb 3, 2025
sjameelTT
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
We need to increase sweep test coverage of our ops.
What's changed
Added sweep tests for multiple ops
Pass rates for new sweeps:
sweeps/eltwise/binary/rpow/rpow.py: 3 fail, 381 pass (99%)
sweeps/eltwise/binary/rpow/rpow_sharded.py: 87 fail, 297 pass (77%)
sweeps/eltwise/binary/ldexp/ldexp_sharded.py: 640 fail, 128 pass (15%)
sweeps/eltwise/binary/logaddexp/logaddexp_sharded.py: 940 fail, 212 pass (18%)
sweeps/eltwise/binary/logaddexp2/logaddexp2_sharded.py: 1139 fail, 13 pass (1%)
sweeps/eltwise/binary/isclose/isclose.py: 3 fail, 765 pass (99%)
sweeps/eltwise/binary/isclose/isclose_sharded.py: 169 fail, 599 pass (77%)
sweeps/eltwise/binary_backward/ldexp_bw/ldexp_bw_sharded.py: 84 fail, 300 pass (78%)
sweeps/eltwise/binary_backward/logaddexp_bw/logaddexp_bw_sharded.py: 84 fail, 300 pass (78%)
sweeps/eltwise/binary_backward/logaddexp2_bw/logaddexp2_bw_sharded.py: 84 fail, 300 pass (78%)
sweeps/eltwise/binary_bw/sub_bw/sub_bw_sharded.py: 768 fail, 0 pass (0%)
sweeps/eltwise/unary_bw/sub_bw/sub_bw.py: 0 fail, 768 pass (100%)
sweeps/eltwise/unary_bw/sub_bw/sub_bw_sharded.py: 768 fail, 0 pass (0%)
sweeps/eltwise/binary_bw/atan2/atan2.py: 768 fail, 0 pass (0%)
sweeps/eltwise/binary_bw/atan2/atan2_sharded.py: 768 fail, 0 pass (0%)
sweeps/eltwise/binary/polyval/polyval_sharded.py: 174 fail, 594 pass (77%)
Checklist