Removing skip_for_blackhole and fix some minor issues for blackhole conv2d #17222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrsticTT
force-pushed
the
skrstic/enable-bh-tests
branch
from
c5b8abc to
1733874
Compare
pavlejosipovic
approved these changes
Jan 30, 2025
| @@ -879,7 +878,6 @@ def test_resnet50_conv_gs( | |||
|
|
|||
|
|
|||
| @skip_for_grayskull() | |||
There was a problem hiding this comment.
remove import for skip_blackhole
skrsticTT
force-pushed
the
skrstic/enable-bh-tests
branch
from
1733874 to
0a7e18c
Compare
skrsticTT
force-pushed
the
skrstic/enable-bh-tests
branch
from
0a7e18c to
8247e37
Compare
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
…onv2d (tenstorrent#17222) ### Issues tenstorrent#17221 tenstorrent#17216 ### Problem description Enable conv2d blackhole tests - to begin with, remove the skips in `tests/ttnn/unit_tests/operations/test_new_conv2d.py` and provide a report about state of tests. Fix minor bugs described in issues. ### What's changed - Removed `@skip_for_blackhole()` for tests that already run on wormhole_b0 - Removed skip for tests that needs 8x8 grid for blackhole - it caused OOM for 8x7 grid on wormhole_b0, it should not be case on blackhole - Removed some unused imports and functions from - Changed alignment of an output tensor in `calculate_L1_usage` function - Removed fatals for num_cores in width sharded factory - Added workaround for shallow convs (from [tenstorrent#17058](tenstorrent#17058), fyi @mywoodstock) - Changed act_block_w_div from 2 to 1 in some tests (this value is correlated with the number of input channels and grid size; 2 becomes invalid in these cases for blackhole due to the increased grid size) ### State of blackhole tests after this changes repro: `pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py` PASSED: 2301 FAILED: 8 99.7% pass rate Of the tests that fail: 8 of them fail because of PCC error - tenstorrent#17226 ### Checklist - [x] Post commit CI passes - https://github.com/tenstorrent/tt-metal/actions/runs/13058074023 - [ ] Blackhole Post commit (if applicable) - [x] Model regression CI testing passes (if applicable) - https://github.com/tenstorrent/tt-metal/actions/runs/13070618785 - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#17221
#17216
Problem description
Enable conv2d blackhole tests - to begin with, remove the skips in
tests/ttnn/unit_tests/operations/test_new_conv2d.pyand provide a report about state of tests. Fix minor bugs described in issues.What's changed
@skip_for_blackhole()for tests that already run on wormhole_b0calculate_L1_usagefunctionState of blackhole tests after this changes
repro:
pytest tests/ttnn/unit_tests/operations/test_new_conv2d.pyPASSED: 2301
FAILED: 8
99.7% pass rate
Of the tests that fail:
8 of them fail because of PCC error - #17226
Checklist