#14186: Fixed moreh_adam and moreh_adamw #14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakoviichuk-tt
requested review from
razorback3,
dongjin-na,
cfjchu and
ayerofieiev-tt
as code owners
rfurko-tt
changed the title
ayerofieiev-tt
approved these changes
Oct 24, 2024
|
@dmakoviichuk-tt Would you mind if I push the patch for |
|
will do it. |
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this pull request
Nov 12, 2024
* tenstorrent#14186: Fixed moreh_adam * #0: fixed adam too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14186
Problem description
Here are some issues with hash computation so I used another version of the hash
What's changed
First idea is that something wrong with lr passing.
But when I added it back to cache I found it doesn't work.
Checklist