Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12849: Replace TT_ASSERT with TT_FATAL in all cnn ops #14018

Merged
merged 1 commit into from
Oct 23, 2024
Merged

#12849: Replace TT_ASSERT with TT_FATAL in all cnn ops #14018

merged 1 commit into from
Oct 23, 2024

Conversation

mywoodstock
Copy link
Contributor

@mywoodstock mywoodstock commented Oct 18, 2024 •
edited
Loading

Ticket

#12849

Problem description

TT_ASSERT works only in Debug mode, is not caught by CI.

What's changed

Relevant TT_ASSERTs have been changed to TT_FATAL for CNN ops.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@mywoodstock mywoodstock marked this pull request as ready for review October 21, 2024 16:24
@mywoodstock mywoodstock force-pushed the asarje/conv-assert-to-fatal branch 3 times, most recently from 258bf33 to d61139c Compare October 21, 2024 23:23
@mywoodstock mywoodstock force-pushed the asarje/conv-assert-to-fatal branch from d61139c to 40c945e Compare October 23, 2024 00:47
@mywoodstock mywoodstock merged commit 16e18b1 into main Oct 23, 2024
7 checks passed
@mywoodstock mywoodstock deleted the asarje/conv-assert-to-fatal branch October 23, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavlejosipovic pavlejosipovic pavlejosipovic approved these changes

@bbradelTT bbradelTT bbradelTT approved these changes

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@sankarmanoj-tt sankarmanoj-tt Awaiting requested review from sankarmanoj-tt

@shwetankTT shwetankTT Awaiting requested review from shwetankTT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mywoodstock @pavlejosipovic @bbradelTT @ayerofieiev-tt