#12955: cleanup device close #13890
Merged
#12955: cleanup device close #13890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliuTT
requested review from
abhullar-tt,
pgkeller,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
5 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cfjchu
reviewed
Oct 17, 2024
cfjchu
reviewed
Oct 17, 2024
cfjchu
reviewed
Oct 17, 2024
aliuTT
force-pushed
the
aliu/device-close-cleanup
branch
from
f17f918 to
0a8527c
Compare
tt-aho
approved these changes
Oct 21, 2024
cfjchu
approved these changes
Oct 21, 2024
aliuTT
force-pushed
the
aliu/device-close-cleanup
branch
from
aac81a0 to
fc1750a
Compare
aliuTT
force-pushed
the
aliu/device-close-cleanup
branch
from
fc1750a to
312d4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Close devices needs some cleanup.
What's changed
Move CloseDevices functionality to DevicePool. Setup better control for device close.
Checklist