Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10548: Support tile layout for width/height-sharded concat #13514

Closed
wants to merge 3 commits into from

Conversation

jerrysky3
Copy link
Contributor

@jerrysky3 jerrysky3 commented Oct 7, 2024

Ticket

#10548

Problem description

Change kernel to support concat on both width and height-sharded tensors in tile layout. The kernel supports the following cases:

  • Height-sharded width concat in row-major/tile layout
  • Width-sharded height concat in row-major/tile layout

This is based on #13314 and need to wait for it to merge first

What's changed

  • Rename and change s2s_rm_concat_multi_core to s2s_concat_multi_core to support tile layout besides the row-major layout
  • Rename reader_s2s_rm_tensor_concat.cpp to reader_s2s_tensor_concat.cpp

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@jerrysky3
Copy link
Contributor Author

Closed in favor of #13744

@jerrysky3 jerrysky3 closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant