Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stable Diffusion 1.4 on Blackhole #17725

Open
15 tasks
s-jovic opened this issue Feb 7, 2025 · 1 comment
Open
15 tasks

Support Stable Diffusion 1.4 on Blackhole #17725

s-jovic opened this issue Feb 7, 2025 · 1 comment

Comments

@s-jovic
Copy link
Contributor

s-jovic commented Feb 7, 2025

All components: https://github.com/tenstorrent/tt-metal/tree/main/models/demos/wormhole/stable_diffusion/tt

Concluding with downsample and midblock tests (PR) , we will have unit tests for all SD components, currently working on Wormhole. Each component needs to be tested on Blackhole and fixed if needed. The following order goes from the simplest components to the more complex ones:

  • upsample nearest - works unchanged; to check configs
  • upsample - works unchanged; to check configs
  • downsample - works unchanged; to check configs
  • embedding - works unchanged; to check configs
  • feedforward - works unchanged; to check configs
  • geglu - works unchanged; to check configs
  • cross attention - works unchanged; to check configs
  • basic transformer block - works unchanged; to check configs
  • transformer 2d - layernorm op grid error (affects cross attn down/up blocks)
  • resnet - pcc issues (affects down and up block)
  • downblock - pcc issues
  • upblock - pcc issues
  • midblock - layernorm op grid error
  • cross attention down block - layernorm op grid error
  • cross attention up block - layernorm op grid error

Note: Even components that work out of the box need to be double checked since sharding schemes and other configs might be changed in other components affecting them.

@s-jovic s-jovic self-assigned this Feb 7, 2025
@s-jovic s-jovic changed the title Support Stable Diffusion on Blackhole Support Stable Diffusion 1.4 on Blackhole Feb 7, 2025
@s-jovic
Copy link
Contributor Author

s-jovic commented Feb 7, 2025

@pavlejosipovic @cmaryanTT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant