Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCC failure from ttnn.moreh_norm for non-last dim #16335

Open
jdh8 opened this issue Dec 27, 2024 · 4 comments
Open

PCC failure from ttnn.moreh_norm for non-last dim #16335

jdh8 opened this issue Dec 27, 2024 · 4 comments
Assignees
@thd1007
Labels
bug Something isn't working moreh moreh contribution op_cat: reduces P2

Comments

@jdh8
Copy link
Contributor

jdh8 commented Dec 27, 2024

Describe the bug
When dim is not the last dimension (-1), accuracy of ttnn.moreh_norm drops.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Lower aten.linalg_vector_norm to ttnn.moreh_norm pytorch2.0_ttnn#686
  2. Run pytest tests/lowering/reduction/test_vector_norm.py --runxfail
  3. See PCC errors
FAILED tests/lowering/reduction/test_vector_norm.py::test_vector_norm[input_shape1-2-2] - AssertionError: 0.9977884821398946
FAILED tests/lowering/reduction/test_vector_norm.py::test_vector_norm[input_shape2-2-1] - AssertionError: 0.9045130848989367

Expected behavior
PCC tests pass.

Please complete the following environment information:

  • OS: Ubuntu 20.04
  • Version of software: v0.54.0-rc9 (9879b37)
@jdh8 jdh8 added the bug Something isn't working label Dec 27, 2024
jdh8 added a commit to tenstorrent/pytorch2.0_ttnn that referenced this issue Dec 27, 2024
@jdh8
Mark known PCC issue with ttnn.moreh_norm (tenstorrent/tt-metal#16335)
67684b8
@jdh8 jdh8 mentioned this issue Dec 27, 2024
Open
5 tasks
@jdh8 jdh8 added moreh moreh contribution op_cat: reduces labels Dec 27, 2024
@zzigler-tt zzigler-tt added the P2 label Jan 16, 2025
@razorback3
Copy link
Contributor

@mrshaw01
Would you assign our engineer for this issue?

@mrshaw01
Copy link
Contributor

@thd1007 let's take a look

@thd1007
Copy link
Contributor

thd1007 commented Jan 16, 2025 •
edited
Loading

@jdh8 what is your expected pcc? vector_norm implementation utilizes multiple operations with a fairly high impact on accuracy (namely exp and log).

@zzigler-tt
Copy link

@jdh8 can you please provide feedback to the prior comment? TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thd1007 thd1007

Labels
bug Something isn't working moreh moreh contribution op_cat: reduces P2
Projects
PyTorch 2.0 TT-NN Compiler
Status: No status
Milestone
No milestone
Development

No branches or pull requests
5 participants
@razorback3 @jdh8 @thd1007 @mrshaw01 @zzigler-tt