Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build toolchain w/ RAW hazard workaround #14596

Closed
pgkeller opened this issue Nov 1, 2024 · 2 comments
Closed

build toolchain w/ RAW hazard workaround #14596

pgkeller opened this issue Nov 1, 2024 · 2 comments

Comments

@pgkeller
Copy link
Contributor

pgkeller commented Nov 1, 2024

currently the toolchain is built w/ vanilla flags
should build the toolchain w/ multilib for GS/WH
remove the workaround for BH

@nathan-TT
Copy link
Contributor

Multilibs are now enabled. I have not yet updated tt-metal's toolchain. Working on a few more issues first.

nathan-TT added a commit that referenced this issue Feb 10, 2025
### Ticket
#14596
#16603

### Problem description
* need per-cpu multilibs so that GS & WH standard libraries are built
with cpu-specific silicon workarounds
* Fix a bunch of compiler internal inconsistencies found by enabling
checking

### What's changed
New gcc toolchain
Fix declaration mismatch discovered by fixed compiler

### Checklist
- [yes ] [All post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml)
CI passes
- [yes] [Blackhole Post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml)
CI passes (if applicable)
- [ ] [Model
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml)
CI passes (if applicable)
- [ ] [Device performance
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml)
CI passes (if applicable)
- [ ] **(For models and ops writers)** Full [new models
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
CI passes (if applicable)
- [ ] New/Existing tests provide coverage for changes
@nathan-TT
Copy link
Contributor

Resolved with #17800

caixunshiren pushed a commit that referenced this issue Feb 11, 2025
### Ticket
#14596
#16603

### Problem description
* need per-cpu multilibs so that GS & WH standard libraries are built
with cpu-specific silicon workarounds
* Fix a bunch of compiler internal inconsistencies found by enabling
checking

### What's changed
New gcc toolchain
Fix declaration mismatch discovered by fixed compiler

### Checklist
- [yes ] [All post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml)
CI passes
- [yes] [Blackhole Post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml)
CI passes (if applicable)
- [ ] [Model
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml)
CI passes (if applicable)
- [ ] [Device performance
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml)
CI passes (if applicable)
- [ ] **(For models and ops writers)** Full [new models
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
CI passes (if applicable)
- [ ] New/Existing tests provide coverage for changes
daminakaTT added a commit that referenced this issue Feb 15, 2025
daminakaTT added a commit that referenced this issue Feb 18, 2025
hschoi4448 pushed a commit that referenced this issue Feb 20, 2025
### Ticket
#14596
#16603

### Problem description
* need per-cpu multilibs so that GS & WH standard libraries are built
with cpu-specific silicon workarounds
* Fix a bunch of compiler internal inconsistencies found by enabling
checking

### What's changed
New gcc toolchain
Fix declaration mismatch discovered by fixed compiler

### Checklist
- [yes ] [All post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml)
CI passes
- [yes] [Blackhole Post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml)
CI passes (if applicable)
- [ ] [Model
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml)
CI passes (if applicable)
- [ ] [Device performance
regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml)
CI passes (if applicable)
- [ ] **(For models and ops writers)** Full [new models
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
CI passes (if applicable)
- [ ] New/Existing tests provide coverage for changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants