This repository has been archived by the owner on Feb 20, 2025. It is now read-only.
#13548: Remove default argument for DstSync #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amahmudTT
force-pushed
the
amahmud/remove_default_dst_sync
branch
from
7edbfc7 to
a73793f
Compare
|
Passing post commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/11310071948 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default argument value for DstSync as this is determined using compute kernel config and we do not want it to conflict with the config if user does not provide the value specifically and relies on the default value.
Corresponding PR for tt-metal : tenstorrent/tt-metal#13661