#14604: Optimize Blackhole muladd negation

tenstorrent · Feb 25, 2025 · 6c3e71d · 6c3e71d
1 parent da9272b
commit 6c3e71d
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 13 deletions.
diff --git a/binutils b/binutils
diff --git a/gcc b/gcc
diff --git a/include/blackhole/sfpi_imp.h b/include/blackhole/sfpi_imp.h
@@ -89,9 +89,8 @@ sfpi_inline __vCond vFloat::operator>=(const float x) const { return __vCond(__v
 
 sfpi_inline vFloat vFloat::operator-=(const vFloat a)
 {
-    __rvtt_vec_t neg1 = __builtin_rvtt_sfpassignlreg(vConstNeg1.get());
-    assign(__builtin_rvtt_sfpmad(neg1, a.get(), v, SFPMAD_MOD1_OFFSET_NONE));
-    return v;
+  *this += -a;
+  return *this;
 }
 
 sfpi_inline vFloat::vFloat(const __vDReg dreg)

diff --git a/include/grayskull/sfpi_imp.h b/include/grayskull/sfpi_imp.h
@@ -90,9 +90,8 @@ sfpi_inline __vCond vFloat::operator>=(const float x) const { return __vCond(__v
 
 sfpi_inline vFloat vFloat::operator-=(const vFloat a)
 {
-    __rvtt_vec_t neg1 = __builtin_rvtt_sfpassignlreg(vConstNeg1.get());
-    assign(__builtin_rvtt_sfpmad(neg1, a.get(), v, SFPMAD_MOD1_OFFSET_NONE));
-    return v;
+  *this += -a;
+  return *this;
 }
 
 sfpi_inline vFloat::vFloat(const __vDReg dreg)

diff --git a/include/sfpi.h b/include/sfpi.h
@@ -759,8 +759,7 @@ sfpi_inline vFloat fp_mul(const vFloat a, const vFloat b)
 
 sfpi_inline vFloat fp_sub(const vFloat a, const vFloat b)
 {
-    __rvtt_vec_t neg1 = __builtin_rvtt_sfpassignlreg(vConstNeg1.get());
-    return __builtin_rvtt_sfpmad(neg1, b.get(), a.get(), 0);
+  return a + -b;
 }
 
 }

diff --git a/include/wormhole/sfpi_imp.h b/include/wormhole/sfpi_imp.h
@@ -89,9 +89,8 @@ sfpi_inline __vCond vFloat::operator>=(const float x) const { return __vCond(__v
 
 sfpi_inline vFloat vFloat::operator-=(const vFloat a)
 {
-    __rvtt_vec_t neg1 = __builtin_rvtt_sfpassignlreg(vConstNeg1.get());
-    assign(__builtin_rvtt_sfpmad(neg1, a.get(), v, SFPMAD_MOD1_OFFSET_NONE));
-    return v;
+  *this += -a;
+  return *this;
 }
 
 sfpi_inline vFloat::vFloat(const __vDReg dreg)
+3 −2		gas/config/tc-riscv.c
+22 −0		gas/testsuite/gas/riscv/tt/muladd-bh.d
+14 −0		gas/testsuite/gas/riscv/tt/muladd-bh.s
+250 −131		gcc/config/riscv/tt/gimple-rvtt-combine.cc
+10 −2		gcc/config/riscv/tt/rvtt.h
+86 −0		gcc/testsuite/g++.target/tt/sfpi/fpsub-14604-bh.C
+84 −0		gcc/testsuite/g++.target/tt/sfpi/fpsub-14604-gs.C
+86 −0		gcc/testsuite/g++.target/tt/sfpi/fpsub-14604-wh.C
+80 −0		gcc/testsuite/g++.target/tt/sfpi/muladd-14604-bh.C
+80 −0		gcc/testsuite/g++.target/tt/sfpi/muladd-14604-wh.C