Lower aten.linalg_vector_norm to ttnn.moreh_norm
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I consistently observe PCC errors for reduction along non-last dimension ``` FAILED tests/lowering/reduction/test_vector_norm.py::test_vector_norm[input_shape1-2-2] - AssertionError: 0.9976093101814988 FAILED tests/lowering/reduction/test_vector_norm.py::test_vector_norm[input_shape2-2-1] - AssertionError: 0.8991108908766973 ```
| try: | ||
| ndims = len(x.meta["val"].size()) | ||
| dim = [d if d >= 0 else d + ndims for d in dim] | ||
| except: |
There was a problem hiding this comment.
what exception does this cause?
There was a problem hiding this comment.
If the shape of x is not known at compile time, x.meta["val"].size() fails.
There was a problem hiding this comment.
maybe then better to handle inside the target wrapper where values are already known?
There was a problem hiding this comment.
I change it to more graceful get_shape
Is there a ticket? |
I doubt if this makes a difference in Python though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Problem description
Compile
aten.linalg_vector_normtottnn.moreh_norm, the PyTorch FX wrapper forttnn.operations.moreh.norm.I consistently observe PCC errors for reduction along non-last dimension. I am reporting this as a kernel issue:
ttnn.moreh_normfor non-last dim tt-metal#16335What's changed