Add INT32 support to SUB #3037
Open
Add INT32 support to SUB #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddavis-2015
suggested changes
Mar 4, 2025
There was a problem hiding this comment.
@HemanthSai7 Thank you for your interest in TFLM (RTLM) and for submitting this PR!
Please add the following to SubPrepare in the sub_common.cc file:
if (output->type == kTfLiteInt32) {
// Only support INT32 unquantized SUB for now.
TF_LITE_ENSURE_EQ(context, input1->quantization.type,
kTfLiteNoQuantization);
TF_LITE_ENSURE_EQ(context, input2->quantization.type,
kTfLiteNoQuantization);
TF_LITE_ENSURE_EQ(context, output->quantization.type,
kTfLiteNoQuantization);
}
Comment on lines
+243
to
+254
| TF_LITE_MICRO_TEST(Int32SubNoActivation) { | ||
| int inout_shape[] = {4, 1, 2, 2, 1}; | ||
| const int32_t input1_values[] = {-2, 2147483646, -1, 1146622854}; | ||
| const int32_t input2_values[] = {3, 1, -2147483647, -726978367}; | ||
| const int32_t golden_values[] = {-5, 2147483645, 2147483646, 1873601221}; | ||
| const int kOutputDimsCount = 4; | ||
| int32_t output_data[kOutputDimsCount]; | ||
| tflite::testing::TestSubInt32(inout_shape, input1_values, inout_shape, | ||
| input2_values, inout_shape, golden_values, | ||
| kTfLiteActNone, output_data); | ||
| } | ||
|
|
There was a problem hiding this comment.
This code will need #if !defined(XTENSA) around it in order to pass the CI tests.
| @@ -147,7 +184,7 @@ TfLiteStatus SubEval(TfLiteContext* context, TfLiteNode* node) { | |||
| TFLITE_DCHECK(node->user_data != nullptr); | |||
| const OpDataSub& data = *(static_cast<const OpDataSub*>(node->user_data)); | |||
|
|
|||
| if (output->type == kTfLiteFloat32) { | |||
| if (output->type == kTfLiteFloat32 || output->type == kTfLiteInt32) { | |||
| EvalSub(context, node, params, &data, input1, input2, output); | |||
There was a problem hiding this comment.
Could you add a TF_LITE_ENSURE_OK check here (line 188). It will make the code more consistent.
|
Also, another Google procedural requirement: All changed files should have the copyright year set the to current year. Only the current year should appear in the copyright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug=fixes #2720