Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add int16 support to PACK/UNPACK #2737

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add int16 support to PACK/UNPACK #2737

wants to merge 5 commits into from
+68 −55

Conversation

andresovela
Copy link
Contributor

This PR adds int16 support for PACK and UNPACK ops.

bug=#2736

@andresovela andresovela requested a review from a team as a code owner October 29, 2024 14:30
@andresovela
Copy link
Contributor Author

Not sure what's the deal with the failing CI

@andresovela andresovela mentioned this pull request Nov 25, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Dec 10, 2024
@andresovela
Copy link
Contributor Author

Needs review

@ddavis-2015 ddavis-2015 removed the Stale label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Jan 20, 2025
@andresovela
Copy link
Contributor Author

Needs review

@github-actions github-actions bot removed the Stale label Jan 21, 2025
ddavis-2015
ddavis-2015 suggested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@ddavis-2015 ddavis-2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresovela Thank you for your interest in TFLM (RTLM) and for submitting this PR!
Also, thank you for your persistence and perseverance.

This change looks good. Please make sure to merge with the latest main branch so there are no conflicts.

Also, another Google procedural requirement: All changed files should have the copyright year set the to current year (I know you submitted this last year). Only the current year should appear in the copyright.

@andresovela
Copy link
Contributor Author

Addressed concerns :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddavis-2015 ddavis-2015 ddavis-2015 requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@andresovela andresovela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresovela @ddavis-2015 @TFLM-bot