Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

C++ API test with synthetic data #284

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

C++ API test with synthetic data #284

wants to merge 1 commit into from

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Jan 17, 2022

Test program to run TF-TRT conversion with the C++API with synthetic data.

This is based on #271

Todo

  • rename / clean up files
  • script to launch test

@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 4 times, most recently from dd03467 to 653ea0a Compare March 11, 2022 20:52
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 3 times, most recently from cf30938 to 8d2c59f Compare April 7, 2022 01:06
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 3 times, most recently from 27ef7b8 to 535c132 Compare May 10, 2022 21:42
@DEKHTIARJonathan
Copy link
Contributor

@meena-at-work: for review

meena-at-work
meena-at-work reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@meena-at-work meena-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks fine to me as is -- considering that it is intended to be a standalone example of using synthetic data (and not a benchmark). If you can address the one small nit, I think it's good to go.

tftrt/examples/cpp/image-classification/mnist.h Outdated
// Converts an MNIST Image to a tensorflow Tensor.
tensorflow::Tensor MNISTImageToTensor(int offset, int batch_size);

std::vector<mnist::MNISTImage> images;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit here -- can you name the member variables with a m_images or images_ so we know that they're member variables?

@meena-at-work meena-at-work self-requested a review June 27, 2022 18:30
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 4 times, most recently from cf4f9f4 to 0f999c4 Compare July 26, 2022 01:28
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 8 times, most recently from e8da9e9 to a742619 Compare August 3, 2022 00:54
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 5 times, most recently from f8c43a2 to 41bbfde Compare August 3, 2022 02:00
@DEKHTIARJonathan DEKHTIARJonathan force-pushed the master branch 13 times, most recently from 0c12576 to bfed396 Compare October 21, 2022 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meena-at-work meena-at-work Awaiting requested review from meena-at-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfeher @DEKHTIARJonathan @meena-at-work