Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ORC dataset reader #1383

Merged
merged 6 commits into from
May 1, 2021
Merged

Implement ORC dataset reader #1383

merged 6 commits into from
May 1, 2021

Conversation

oliverhu
Copy link
Contributor

@oliverhu oliverhu commented Apr 28, 2021 •
edited
Loading

  • support double, float and string types
  • add sample keras unit tests

part of #1372

@oliverhu oliverhu marked this pull request as ready for review April 30, 2021 07:37
yongtang
yongtang reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverhu The PR looks good though there are some minor comments.

tensorflow_io/core/kernels/orc/orc_kernels.cc Show resolved Hide resolved
tensorflow_io/core/kernels/orc/orc_kernels.cc Outdated Show resolved Hide resolved
tensorflow_io/core/ops/orc_ops.cc Outdated Show resolved Hide resolved
tests/test_orc.py Outdated Show resolved Hide resolved
tests/test_orc.py Outdated Show resolved Hide resolved
@oliverhu
Copy link
Contributor Author

oliverhu commented May 1, 2021

@yongtang updated. Btw, will follow up in next PRs for nested schemas.

yongtang
yongtang approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR and looking forward to the follow up on the nested field. 👍

@yongtang yongtang merged commit ce521ae into tensorflow:master May 1, 2021
yongtang pushed a commit to yongtang/io that referenced this pull request May 8, 2021
@oliverhu @yongtang
Implement ORC dataset reader (tensorflow#1383)
f163ee1 
* Implement ORC dataset reader

* support double, float and string types
* add sample keras unit tests

* reset unintended changes

* add more datatypes

* fix type in macOS, add test

* address comments

* fix a typo in float conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongtang yongtang yongtang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverhu @yongtang