Make UI testing significantly more robust #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
force-pushed
the
fix-ci
branch
5 times, most recently
from
c072a72 to
aed7e5c
Compare
edgar-bonet
approved these changes
Nov 29, 2023
@edgar-bonet glad you like it! I don't know if they're a thing, maybe I just invented something new 😄 I definitely did some testing both in CI and locally. The future will tell what I missed 😃 PS: Do you know # ./recordings/flip_book.py sl
[90x20] Frame 1:
+------------------------------------------------------------------------------------------+
| (@@@) |
| ( ) |
| (@@@@) |
| |
| ( ) |
| ==== _______|
| _D _| |_______/ |
| |(_)--- | H\_______|
| / | | H | | |
| | | | H |__---|
| | ________|___H__/__|__|
| |/ | |-----------I___|
| __/ =| o |=-~~\ /~~\ /~|
| |/-=|___|= O=====O====|
| \_/ \__/ \__/ \_|
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+
[90x20] Frame 2:
+------------------------------------------------------------------------------------------+
| (@@@) |
| ( ) |
| (@@@@) |
| |
| ( ) |
| ==== ________ ________|
| _D _| |_______/ \__I_I_____===__|_______|
| |(_)--- | H\________/ | | =|___ ___|
| / | | H | | | | ||_| |_||
| | | | H |__--------------------| [___] |
| | ________|___H__/__|_____/[][]~\_______| |
| |/ | |-----------I_____I [][] [] D |=======|
| __/ =| o |=-~O=====O=====O=====O\ ____Y___________|
| |/-=|___|= || || || |_____/~\___/ |
| \_/ \__/ \__/ \__/ \__/ \_/ |
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+
[90x20] Frame 3:
+------------------------------------------------------------------------------------------+
| (@@@) |
| ( ) |
| (@@@@) |
| |
| ( ) |
| ==== ________ ___________ |
| _D _| |_______/ \__I_I_____===__|_________| |
| |(_)--- | H\________/ | | =|___ ___| _________________ |
| / | | H | | | | ||_| |_|| _| \|
| | | | H |__--------------------| [___] | =| |
| | ________|___H__/__|_____/[][]~\_______| | -| |
| |/ | |-----------I_____I [][] [] D |=======|____|___________________|
| __/ =| o |=-O=====O=====O=====O \ ____Y___________|__|_____________________|
| |/-=|___|= || || || |_____/~\___/ |_D__D__D_| |_D__D|
| \_/ \__/ \__/ \__/ \__/ \_/ \_/ \_/ \_/ |
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+
[90x20] Frame 4:
+------------------------------------------------------------------------------------------+
| (@@@) |
| ( ) |
| (@@@@) |
| |
|( ) |
| ________ ___________ |
|_______/ \__I_I_____===__|_________| |
| | H\________/ | | =|___ ___| _________________ |
| | H | | | | ||_| |_|| _| \_____A |
| | H |__--------------------| [___] | =| | |
|__|___H__/__|_____/[][]~\_______| | -| | |
|-----------I_____I [][] [] D |=======|____|________________________|_ |
|=-~~\ /~~\ /~~\ /~~\ ____Y___________|__|__________________________|_ |
|=O=====O=====O=====O |_____/~\___/ |_D__D__D_| |_D__D__D_| |
| \__/ \__/ \__/ \__/ \_/ \_/ \_/ \_/ \_/ |
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+
[90x20] Frame 5:
+------------------------------------------------------------------------------------------+
| |
| |
| |
| |
| |
| ___________ |
|__===__|_________| |
| =|___ ___| _________________ |
| ||_| |_|| _| \_____A |
|-------| [___] | =| | |
|_______| | -| | |
|] D |=======|____|________________________|_ |
|___Y___________|__|__________________________|_ |
|____/~\___/ |_D__D__D_| |_D__D__D_| |
| \_/ \_/ \_/ \_/ \_/ |
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+
[90x20] Frame 6:
+------------------------------------------------------------------------------------------+
| |
| |
| |
| |
| |
| |
| |
|______________ |
| \_____A |
| | |
| | |
|____________________|_ |
|____________________|_ |
|_D__D_| |_D__D__D_| |
| \_/ \_/ \_/ |
| |
| |
| |
| |
| |
+------------------------------------------------------------------------------------------+ |
LOL. reminds me of Star Wars. |
hartwork
added a commit
that referenced
this pull request
Dec 1, 2023
…ts-evaluation Clean up CI stage "Evaluate UI test results" (fix-up for #133)
hartwork
added a commit
that referenced
this pull request
Jan 9, 2024
Cl: Drop `homebrew/cask-fonts` leftover (follow-up to #133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #117.
@edgar-bonet you were right about the clock: with differences in hardware capability, there is no way we get this many machines to agree enough on speed of execution… PS: The best point to start review is probably the changes to
record.sh.