Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend attibution #125

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Extend attibution #125

merged 3 commits into from
Nov 27, 2023

Conversation

hartwork
Copy link
Collaborator

No description provided.

@hartwork hartwork requested a review from edgar-bonet November 26, 2023 22:45
edgar-bonet
edgar-bonet approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@edgar-bonet edgar-bonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not care too much about getting attribution here (it's already on the git log), but why not. You may ignore my comment if you feels the rendering is OK for you.

ttyplot.1 Outdated Show resolved Hide resolved
@hartwork hartwork merged commit 4ce426f into tenox7:development Nov 27, 2023
5 checks passed
@hartwork hartwork deleted the extend-attibution branch November 27, 2023 22:15
@hartwork hartwork added this to the 1.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgar-bonet edgar-bonet edgar-bonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hartwork @edgar-bonet