From 740a16e6bf6e2fbcde0979792190fcd38499e3a7 Mon Sep 17 00:00:00 2001
From: Sebastian Pipping <sebastian@pipping.org>
Date: Mon, 27 Nov 2023 02:55:45 +0100
Subject: [PATCH] recordings: Make record.sh ensure recent enough asciinema

---
 .github/workflows/linux_and_macos.yml | 2 +-
 CONTRIBUTING.md                       | 4 ++--
 recordings/record.sh                  | 5 +++++
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/linux_and_macos.yml b/.github/workflows/linux_and_macos.yml
index 31aef32..1a9e3a2 100644
--- a/.github/workflows/linux_and_macos.yml
+++ b/.github/workflows/linux_and_macos.yml
@@ -70,7 +70,6 @@ jobs:
           brew tap homebrew/cask-fonts
           brew install \
             agg \
-            asciinema \
             coreutils \
             font-liberation \
             imagemagick
@@ -114,6 +113,7 @@ jobs:
         if: "${{ runner.os == 'macOS' }}"
         run: |-
           ./recordings/record.sh
+          rm -Rf recordings/venv/
 
       - name: 'Upload UI test renderings for inspection'
         if: "${{ runner.os == 'macOS' }}"
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 8f7378e..5e53c81 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -42,10 +42,10 @@ On a Debian-based Linux including Ubuntu, you would need to install…
 ```console
 $ sudo apt-get update
 $ sudo apt-get install --no-install-recommends -V \
-    asciinema \
     ca-certificates \
     cargo \
-    fonts-liberation
+    fonts-liberation \
+    python3-venv
 $ cargo install --git https://github.com/asciinema/agg
 ```
 
diff --git a/recordings/record.sh b/recordings/record.sh
index b207b43..4758483 100755
--- a/recordings/record.sh
+++ b/recordings/record.sh
@@ -18,6 +18,11 @@ export FAKETIME=yesplease
 
 cd "${self_dir}"
 
+# Ensure recent asciinema with --cols and --rows argument support
+[[ -d venv/ ]] || python3 -m venv venv/
+source venv/bin/activate
+pip3 install asciinema==2.3.0
+
 # Check and report on runtime requirements
 which agg asciinema convert realpath timeout ttyplot