Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand arguments in UpdateWorkflow call when args equal one #1799

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Expand arguments in UpdateWorkflow call when args equal one #1799

merged 4 commits into from
Feb 7, 2025

Conversation

disco07
Copy link
Contributor

@disco07 disco07 commented Feb 3, 2025

What was changed

Ensure UpdateWorkflowNoRejection is correctly triggered with one or variadic arguments.

Why?

It's a bug in unit test.

Checklist

  1. Closes
  2. How was this tested
  3. Any docs updates needed?

@disco07 disco07 requested a review from a team as a code owner February 3, 2025 13:26
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Quinn-With-Two-Ns
Copy link
Contributor

@yuandrew Do you mind taking a look as well?

yuandrew
yuandrew approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yuandrew yuandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@yuandrew yuandrew merged commit 6e75f6d into temporalio:master Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@yuandrew yuandrew yuandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disco07 @CLAassistant @Quinn-With-Two-Ns @yuandrew