Skip to content

Commit

Permalink
Add OnConflictOptions to StartWorkflowExecutionRequest (#510)
Browse files Browse the repository at this point in the history
_**READ BEFORE MERGING:** All PRs require approval by both Server AND
SDK teams before merging! This is why the number of required approvals
is "2" and not "1"--two reviewers from the same team is NOT sufficient.
If your PR is not approved by someone in BOTH teams, it may be summarily
reverted._

<!-- Describe what has changed in this PR -->
**What changed?**
Add `OnConflictOptions` to `StartWorkflowExecutionRequest`

<!-- Tell your future self why have you made these changes -->
**Why?**
When the workflow id conflict policy is `USE_EXISTING`,
`OnConflictOptions` add the ability to change the existing running
workflow.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
temporalio/temporal#7080
  • Loading branch information
rodrigozhou committed Feb 3, 2025
1 parent c83bb3e commit 1f14206
Show file tree
Hide file tree
Showing 7 changed files with 3,628 additions and 3,464 deletions.
1,757 changes: 893 additions & 864 deletions history/v1/message.pb.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion temporalproto/openapi/openapiv2.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion temporalproto/openapi/openapiv3.go

Large diffs are not rendered by default.

37 changes: 37 additions & 0 deletions workflow/v1/message.go-helpers.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

325 changes: 202 additions & 123 deletions workflow/v1/message.pb.go

Large diffs are not rendered by default.

4,967 changes: 2,493 additions & 2,474 deletions workflowservice/v1/request_response.pb.go

Large diffs are not rendered by default.

0 comments on commit 1f14206

Please sign in to comment.