Use regex for gutterInjection line splitting #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @brendt, as mentioned on #104 I have a specific scenario where gutterInjection shows only on the first line (all other cases work as expected). It seems like the issue is the way you line splitting the content using
explode(PHP_EOL, $content)
as it has limited flexibility when handling all line break conventions correctly.Given this I've switched to
preg_split('/\R/', trim($content))
which offers more versatility and flexibility, solving my specific scenario. From my testing, it should work in most environments and be a more reliable solution.