Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store / recover previous jextctxt #1691

Merged
merged 17 commits into from
Jan 31, 2025
Merged

store / recover previous jextctxt #1691

merged 17 commits into from
Jan 31, 2025

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jan 28, 2025

Fix for #1690

@AlvaroVega AlvaroVega marked this pull request as ready for review January 29, 2025 09:38
@AlvaroVega AlvaroVega requested a review from fgalan January 29, 2025 15:54
Comment on lines -2001 to +2005
| `payloadType` | ✓ | `string` | | optional string value used to switch between **IoTAgent**, **NGSI-v2** and **NGSI-LD** measure payloads types. Possible values are: `iotagent`, `ngsiv2` or `ngsild`. The default is `iotagent`. |
| `storeLastMeasure` | ✓ | `boolean` | | Store in device last measure received. See more info [in this section](admin.md#storelastmeasure). False by default. |
| `lastMeasure` | ✓ | `object` | | last measure stored on device when `storeLastMeasure` is enabled. See more info [in this section](admin.md#storelastmeasure). This field can be cleared using `{}` in a device update request. In that case, `lastMeasure` is removed from device (until a next measure is received and `lastMesuare` gets created again). |
| `useCBflowControl` | ✓ | `boolean` | | Use Context Broker flow control. See more info [in this section](admin.md#useCBflowControl). False by default. |
| `payloadType` | ✓ | `string` | | optional string value used to switch between **IoTAgent**, **NGSI-v2** and **NGSI-LD** measure payloads types. Possible values are: `iotagent`, `ngsiv2` or `ngsild`. The default is `iotagent`. |
| `storeLastMeasure` | ✓ | `boolean` | | Store in device last measure received. Useful just for debugging purpose. See more info [in this section](admin.md#storelastmeasure). False by default. |
| `lastMeasure` | ✓ | `object` | | last measure stored on device when `storeLastMeasure` is enabled. See more info [in this section](admin.md#storelastmeasure). This field can be cleared using `{}` in a device update request. In that case, `lastMeasure` is removed from device (until a next measure is received and `lastMesuare` gets created again). |
| `useCBflowControl` | ✓ | `boolean` | | Use Context Broker flow control. See more info [in this section](admin.md#useCBflowControl). False by default. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any actual change here? Or it it's just indent/whitespace?

Copy link
Member Author

@AlvaroVega AlvaroVega Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: "Useful just for debugging purpose."

@fgalan
Copy link
Member

fgalan commented Jan 30, 2025

Maybe some test should be included to cover the new functionality?

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
@AlvaroVega
Copy link
Member Author

AlvaroVega commented Jan 30, 2025

Maybe some test should be included to cover the new functionality?

Probably in other PR in iotagent-json repository, like storeLastMeasure feature.

@AlvaroVega
Copy link
Member Author

Maybe some test should be included to cover the new functionality?

Probably in other PR in iotagent-json repository, like storeLastMeasure feature.

Test done in telefonicaid/iotagent-json@c910997

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit dac908d into master Jan 31, 2025
7 checks passed
@fgalan fgalan deleted the task/store_previous_jextctxt branch January 31, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants