Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development for changes to LIBRS - JSON Specifications, API Validator: Source code for API endpoints, JSON model changes, and updates to docs.librs.org specifications ready for review in TEI test environment #17

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Development for changes to LIBRS - JSON Specifications, API Validator: Source code for API endpoints, JSON model changes, and updates to docs.librs.org specifications ready for review in TEI test environment #17

merged 7 commits into from
Jul 30, 2024

Conversation

john-maus
Copy link
Contributor

@john-maus john-maus commented Jul 19, 2024 •
edited
Loading

Changes:

  • Corrected documentation for how age is entered and handled.

Asana Tasks Involved:

Testing:

  • Verify that the offender age and estimatedAge documentation matches what Kate specified in the Asana task. [PASSED]
  • Verify that the victim age and estimatedAge documentation matches what Kate specified in the Asana task. [PASSED]
  • Verify that the arrestee age, estimatedAge, and dispositionUnder18 documentation matches what Kate specified in the attachment in the Asana task. [PASSED]
  • Verify that the JSON examples for offender, victim, and arrestee are updated to reflect documentation changes. [PASSED]

Notes:

  • I'm not sure why, but VS Code made some whitespace changes to the markdown file I edited since I opened it in a markdown editing extension within VS Code. @dougbarbin - You may have to scroll past the text in the changes that looks repeated and just worry about the changes for offender, victim, and arrestee. See the Asana tasks involved above for the changes that needed to be made.
  • Also, I forgot to make a new branch for the other document changes I just made, so it got included in this PR and I am updating the description.

@john-maus john-maus added the documentation Improvements or additions to documentation label Jul 19, 2024
@john-maus john-maus requested a review from dougbarbin July 19, 2024 14:25
@john-maus john-maus marked this pull request as ready for review July 19, 2024 14:25
dougbarbin
dougbarbin reviewed Jul 23, 2024
View reviewed changes
_data/data-element-defs.json Outdated
@@ -2319,7 +2319,7 @@
}, {
"de_num": "52",
"name": "DISPOSITION OF ARRESTEE UNDER 18",
"definition": "Used only if the arrestee was 16 years of age or younger at the time of arrest.",
"definition": "Mandatory field for ANY Arrestee that is 17 years of age and younger. The Federal UCR program considers juveniles as under 18 years of age regardless of state law. The LIBRS program will stay aligned with the FBI and collect this field for arrestees 17 and younger even though this differs from the latest state Juvenile Age Definition.\n\nIf the arrestee is 17 and considered an adult in Louisiana after April 19, 2024, please use A – Referred to Criminal or Adult Court.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-maus please re-word this. An Arrestee cannot possibly be 17 years of age AND younger; they can only be one or the other. It should read, "...ANY Arrestee that is 17 years of age or younger."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done.

@dougbarbin
Copy link
Contributor

@john-maus please see my comment about the slight verbiage change. Other than that, this looks good to go.

@dougbarbin
Copy link
Contributor

@john-maus please see my comment about the slight verbiage change. Other than that, this looks good to go.

@kirkes21 - I asked Kate about it. There might be some specific verbiage we have to use. It's a little confusing and the context matters - are we talking about the Arrestee or their age, for example? Here's a different diff (see what I did there) where it explicitly mentions Age, and in that context, "and" definitely makes sense. Plurality might also make a difference (e.g., Arrestees versus Arrestee). Anyways, let's see what Kate says.

image

@john-maus
Copy link
Contributor Author

@john-maus please see my comment about the slight verbiage change. Other than that, this looks good to go.

@kirkes21 - I asked Kate about it. There might be some specific verbiage we have to use. It's a little confusing and the context matters - are we talking about the Arrestee or their age, for example? Here's a different diff (see what I did there) where it explicitly mentions Age, and in that context, "and" definitely makes sense. Plurality might also make a difference (e.g., Arrestees versus Arrestee). Anyways, let's see what Kate says.

image

@dougbarbin I just copied how Kate had it in the word document from the task. I think we should ask her first?

john-maus and others added 4 commits July 24, 2024 09:56
@john-maus
Update data-element-defs.json
f323010 
Corrected "age and younger" to read "age or younger" for proper logic.
@dependabot @john-maus
Bump nokogiri from 1.14.3 to 1.15.6
b5ef045 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.14.3 to 1.15.6.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.14.3...v1.15.6)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@john-maus
Create static.yml
c0c8a1c
@john-maus
Trying PR Preview Pages
d8cfb02
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://teisdbr.github.io/winlibrs-docs/pr-preview/pr-17/
on branch master at 2024-07-24 16:14 UTC

@dougbarbin dougbarbin merged commit 72c4aff into master Jul 30, 2024
1 check passed
@dougbarbin dougbarbin mentioned this pull request Jul 30, 2024
Merged
@dougbarbin
Copy link
Contributor

@john-maus - this broke the https://docs.librs.org site, so I had to revert it.

@dougbarbin dougbarbin deleted the age-changes branch July 31, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbarbin dougbarbin dougbarbin left review comments

Assignees

@dougbarbin dougbarbin

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-maus @dougbarbin