Fix bug in isArray empty

taylorhakes · Jun 15, 2019 · 03f6f9a · 03f6f9a
1 parent e826101
commit 03f6f9a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "promise-polyfill",
-  "version": "8.1.1",
+  "version": "8.1.2",
   "description": "Lightweight promise polyfill. A+ compliant",
   "main": "lib/index.js",
   "module": "src/index.js",

diff --git a/src/index.js b/src/index.js
@@ -5,7 +5,7 @@ import promiseFinally from './finally';
 var setTimeoutFunc = setTimeout;
 
 function isArray(x) {
-  return Boolean(x && x.length);
+  return Boolean(x && typeof x.length !== 'undefined');
 }
 
 function noop() {}

diff --git a/test/promise.js b/test/promise.js
@@ -373,7 +373,7 @@ describe('Promise', function() {
         }
       );
     });
-    it('throws on multiple promises', function() {
+    it('works on multiple resolved promises', function() {
       return Promise.all([Promise.resolve(), Promise.resolve()]).then(
         function() {
           assert.ok(true);
@@ -383,6 +383,16 @@ describe('Promise', function() {
         }
       );
     });
+    it('works on empty array', function() {
+      return Promise.all([]).then(
+        function(arr) {
+          assert.ok(arr.length === 0);
+        },
+        function() {
+          assert.fail();
+        }
+      );
+    });
   });
   describe('Promise.race', function() {
     it('throws on implicit undefined', function() {
@@ -499,5 +509,9 @@ describe('Promise', function() {
         }
       );
     });
+    it('works on empty array', function() {
+      var prom = Promise.race([]);
+      return assert(prom instanceof Promise);
+    });
   });
 });