Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #986 from tatuylonen/split-templates" #1000

Closed

Conversation

ledzeppelin
Copy link

This reverts commit e6a833d, reversing changes made to debb661.

This reverts commit e6a833d, reversing
changes made to debb661.
@ledzeppelin
Copy link
Author

@kristian-clausal - i think i figured out what the issue was, it has to do w/ the large values for colspan and rowspan which is an issue that can be fixed on the wiktionary side

i will need until the next xml dump feb 1st and the subsequent kaikki dump to confirm but let's revert since i dont think the entire parser should be modified bc of how 1 language implemented a couple of templates

@ledzeppelin
Copy link
Author

forgot to add another detail here... the reason this issue is only occurring for the preposition templates but not the noun templates - ie #973 (comment) is bc even though the noun templates set rowspan="999" it isn't a problem since the parent <tr> only contains <th> as opposed to a mix of <th> and <td>

kind of confusing but merging this pr and fixing on the wiktionary side of things is the way to go imo

@kristian-clausal
Copy link
Collaborator

Do not start changing colspand and rowspan on Wiktionary side, it will only annoy the editors who explicitly have in the documentation that you're supposed to use "colspan=999" for this.

@kristian-clausal
Copy link
Collaborator

This reversion is probably not necessary, because the changes made in the revert are still valid changes. The parsing of tables/template starts and ends specifically fixes a bug that's not specific to this issue. There should be no issue with keeping things like this. Please explain the issue with rowspan and colspan in more detail.

@ledzeppelin
Copy link
Author

Do not start changing colspand and rowspan on Wiktionary side, it will only annoy the editors who explicitly have in the documentation that you're supposed to use "colspan=999" for this.

yah you're right, it does specifically mention that in the docs

let me close this PR

@ledzeppelin ledzeppelin deleted the revert-split-template-logic branch January 21, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants