Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

style: replace tables with boostrap cols + css improvements #23

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

tassiluca
Copy link
Owner

This PR includes the following style adjustment proposals:

  • use bootstrap col layout + boostrap flex instead of tables for columns layout

Before
before

After
after

@tassiluca tassiluca changed the title style: replace awful tables with boostrap cols + css improvements style: replace tables with boostrap cols + css improvements Jan 31, 2024
Copy link
Collaborator

@giovaz94 giovaz94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@giovaz94 giovaz94 added the enhancement New feature or request label Jan 31, 2024
@Luca1313
Copy link
Collaborator

Deal on the style change, isn't the voting button missing? If so, how is rendered within it?

@tassiluca
Copy link
Owner Author

@Luca1313

Deal on the style change, isn't the voting button missing? If so, how is rendered within it?

The button is missing because, I don't know why, but they are not correctly categorized in "open", "closed" and "soon". Maybe a regression. I just modified the style.
Anyway, the buttons are aligned horizontally side by side (unless in mobile versions there is not enough space and they are aligned one under the other)

@giovaz94
Copy link
Collaborator

The approval is relative to the style change, I didn't see any error on code side.

@tassiluca tassiluca merged commit e62743c into develop Jan 31, 2024
10 of 12 checks passed
@tassiluca tassiluca deleted the style/elections branch January 31, 2024 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants