fix(flow): consider to fail a parent not in waiting-children #3098
+297
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
When a child with failParentOnFailure is true and this child fail. As it's required to pass a job to waiting-children to verify that all children are completed to continue, we can validate if unsuccessful key has a len greater than 0 to move it to failed instead of waiting-children. Take in count that if users do not use moveToWaitingChildren method, parent would fail anyway as not all children will be completed.
Additional Notes (Optional)
Any extra info here.