Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): consider to fail a parent not in waiting-children #3098

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Feb 22, 2025

Why

  1. Why is this change necessary? When failing a parent we are only considering that it can only be in waiting-children. If it's in another state we do not fail it. This is in the case where failParentOnFailure is true. But we can dynamically add jobs when a parent is active. We should consider to fail a parent later.

How

  1. How did you implement this? A child can be in 4 different stages:
  • unprocessed - dependencies key
  • processed successfully - processed key
  • processed unsuccessfully and ignored - failed key
  • processed unsuccessfully and not ignored - (new key being added as unsuccessful)

When a child with failParentOnFailure is true and this child fail. As it's required to pass a job to waiting-children to verify that all children are completed to continue, we can validate if unsuccessful key has a len greater than 0 to move it to failed instead of waiting-children. Take in count that if users do not use moveToWaitingChildren method, parent would fail anyway as not all children will be completed.

Additional Notes (Optional)

Any extra info here.

@roggervalf roggervalf changed the title fix(flow): consider to fail a parent not in waiting-children fix(flow): consider to fail a parent not in waiting-children [DRAFT] Feb 22, 2025
@roggervalf roggervalf changed the title fix(flow): consider to fail a parent not in waiting-children [DRAFT] fix(flow): consider to fail a parent not in waiting-children Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant