feat: add a queue registry #3030
Open
+189
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Jan 26, 2025
| @@ -0,0 +1 @@ | |||
| export const BullMQRegistryKey = 'bullmq:registry'; | |||
There was a problem hiding this comment.
we use bull as prefix for all our keys, do we really need to change that pattern?
There was a problem hiding this comment.
yes, because this is a global key, if we used a prefix then we would not be able to auto-discover the queues defeating the whole purpose. The idea is that a UI can easily get all the queues available in a Redis instance.
| @@ -1464,6 +1465,7 @@ export class Scripts { | |||
| const client = await this.queue.client; | |||
|
|
|||
| const keys: (string | number)[] = [ | |||
| BullMQRegistryKey, | |||
There was a problem hiding this comment.
we have this class for handling queue keys, https://github.com/taskforcesh/bullmq/blob/master/src/classes/queue-keys.ts we can add a new method to handle global keys
There was a problem hiding this comment.
hmm, this is not really a Queue key, so I am not sure it fits so well on a class that generates queue keys :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To be able to efficiently get all the bullmq queues that are available in a Redis host. This feature makes
queue discovery a mostly O(1) operation instead of O(n).
How
Added a new key with a fixed name: "bullmq:registry", that holds a ZSET with the fully queue qualified names. This queue names will be kept in the registry until the queue is completely obliterated.
Additional Notes (Optional)