-
Notifications
You must be signed in to change notification settings - Fork 38
dev meeting 20220224
Present at the meeting:
- Sonja Heinze (@pitag-ha)
- Marek Kubica (@Leonidas-from-XIV)
Not much has happened on dune-release development since the last meeting, with only Nathan creating PRs.
The Cmdliner 1.1 situation was discussed. We need to have the code in because other tools (ocamlformat, the platform tools) have upgraded to Cmdliner 1.1 and it creates issues. We would release 1.6.1 with just this fix and bump the minimum version to 4.08. In the release announcement we can write that people can still use dune-release to release their projects if they are on older compiler versions, they can have the dune-release binary in e.g. a global switch.
The delegate PR is welcome and it should be rebased on the Cmdliner fix and reviewed and merged afterwards.
Sonja mentioned that dune-release is used in the platform tool and one of the principles in the platform tool is that the tools should not depend on each other's binaries. At the moment, dune-format uses a number of external binaries, like opam, dune, ocamlfind etc. It should be pretty easy to replace the calls to the opam binary with calling the opam libraries. A similar thing should be possible with dune. ocamlfind is only used in one place, to look up the opam binary, so if we drop the binary it would go away naturally.
There is a question about the other Unix utils that we depend on: curl (via curly), tar, bzip etc. If it proves to be an issue (e.g. on Windows) we could try to build the tarballs using OCaml code (mirage's ocaml-tar, camlzip). Replacing git would be a bigger issue.
Sonja raised the question whether we actually support Mercurial (hg). The answer is… probably not. We don't have tests for it, so maybe it accidentally works but we should consider either dropping support for Mercurial or adding tests to it. Marek mentioned that the Mercurial code that is currently in dune-release is not a big maintenance burden so unlike delegates it wouldn't be urgent to deal with Mercurial either way.
Marek asked whether we want to move the dev meeting to the same time as usual (11:30 to 12:15) but Thursday since that works better for Sonja. The time slot works for both Sonja and Marek so unless Nathan objects we suggest keeping it on every other Thursday going forward (thus complementing the opam-monorepo dev meeting).