Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move to qgridnext" #2818

Closed
wants to merge 1 commit into from
Closed

Conversation

andrewfullard
Copy link
Contributor

Reverts #2814.

Unfortunately qgridnext does not seem to resolve the issues with qgrid. Its pip install also makes our conda lock files very difficult to use.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (02bc2d1).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

10	W293	[*] Blank line contains whitespace
4	W291	[*] Trailing whitespace
2	I001	[*] Import block is un-sorted or un-formatted
2	E999	[ ] SyntaxError: Expected an expression
2	F401	[*] `qgrid` imported but unused
1	E712	[*] Avoid equality comparisons to `False`; use `if not ...:` for false checks

Complete output(might be large):

.github/workflows/tests.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/tests.yml:29:205: W291 [*] Trailing whitespace
.github/workflows/tests.yml:35:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:39:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:68:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:73:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:78:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:85:142: W291 [*] Trailing whitespace
.github/workflows/tests.yml:86:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:88:163: W291 [*] Trailing whitespace
.github/workflows/tests.yml:90:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:99:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:113:14: W291 [*] Trailing whitespace
.github/workflows/tests.yml:116:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:122:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/widgets/line_info.py:3:8: F401 [*] `re` imported but unused
tardis/visualization/widgets/line_info.py:8:8: F401 [*] `qgrid` imported but unused
tardis/visualization/widgets/line_info.py:306:21: E712 Avoid equality comparisons to `False`; use `if not ...:` for false checks
tardis/visualization/widgets/util.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis_env3.yml:3:10: E999 SyntaxError: Expected an expression
Found 21 errors.
[*] 18 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).

@jaladh-singhal
Copy link
Member

jaladh-singhal commented Sep 11, 2024

Unfortunately qgridnext does not seem to resolve the issues with qgrid.

@andrewfullard Do you mean issues regarding installation? Or issues in rendering widgets too?

Because I tested latter and they worked. About the former, I built my environment from tardis_env3.yml, do we absolutely need to use conda lock files for visualization use cases?

@andrewfullard
Copy link
Contributor Author

Unfortunately qgridnext does not seem to resolve the issues with qgrid.

@andrewfullard Do you mean issues regarding installation? Or issues in rendering widgets too?

Because I tested latter and they worked. About the former, I built my environment from tardis_env3.yml, do we absolutely need to use conda lock files for visualization use cases?

I created an environment and tested it on a jupyter server, and got the same Java errors as with qgrid. I can double check. Regardless, we have lock files because we want a reproducible environment, and that should extend to visualizations.

@andrewfullard
Copy link
Contributor Author

I tested in VS Code with qgridnext and it appears to be working, which is great. However, it does fail on the older notebook server style ("classicnb") with the Java errors.

@andrewfullard
Copy link
Contributor Author

After discussion- this is being closed in favour of a try-except clause in the import block of qgridnext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants