-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Montecarlo globals (limited scope) #2705
Merged
atharva-2001
merged 5 commits into
tardis-sn:master
from
andrewfullard:montecarlo_globals_limited
Jul 16, 2024
Merged
Montecarlo globals (limited scope) #2705
atharva-2001
merged 5 commits into
tardis-sn:master
from
andrewfullard:montecarlo_globals_limited
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*beep* *bop* Hi, human. The Click here to see your results. |
My attempt to fix codecov values didn't work, can you take a look @atharva-2001 @KasukabeDefenceForce ? |
jvshields
approved these changes
Jul 16, 2024
6 tasks
I'll fix codecov in #2699 or in a new separate PR. |
atharva-2001
approved these changes
Jul 16, 2024
Looks good to me. Merging it! |
sarthak-dv
pushed a commit
to sarthak-dv/tardis
that referenced
this pull request
Jul 16, 2024
* Initial restructure of configs * Continuum processes to global * Fixes mistakes * RPacket tracking global * Split tests for rpacket tracking, move codecov detection for now
sarthak-dv
pushed a commit
to sarthak-dv/tardis
that referenced
this pull request
Jul 16, 2024
* Initial restructure of configs * Continuum processes to global * Fixes mistakes * RPacket tracking global * Split tests for rpacket tracking, move codecov detection for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix
A more limited form of #2697 that only refactors into 2 constants: CONTINUUM_PROCESSES_ENABLED and ENABLE_RPACKET_TRACKING.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label