Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons Hover color #567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added icons Hover color #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/client/containers/NoteMenuBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const NoteMenuBar = () => {
{activeNote && !isDraftNote(activeNote) ? (
<nav>
<button
className="note-menu-bar-button"
className="note-menu-bar-button eye"
onClick={togglePreviewHandler}
data-testid={TestID.PREVIEW_MODE}
>
Expand All @@ -120,7 +120,7 @@ export const NoteMenuBar = () => {
</button>
{!activeNote.scratchpad && (
<>
<button className="note-menu-bar-button" onClick={favoriteNoteHandler}>
<button className="note-menu-bar-button star" onClick={favoriteNoteHandler}>
<Star aria-hidden="true" size={18} />
<span className="sr-only">Add note to favorites</span>
</button>
Expand All @@ -130,12 +130,12 @@ export const NoteMenuBar = () => {
</button>
</>
)}
<button className="note-menu-bar-button">
<button className="note-menu-bar-button download">
<Download aria-hidden="true" size={18} onClick={downloadNotesHandler} />
<span className="sr-only">Download note</span>
</button>
<button
className="note-menu-bar-button uuid"
className="note-menu-bar-button uuid icon-hover"
onClick={() => {
copyToClipboard(`{{${shortNoteUuid}}}`)
setUuidCopiedText(successfulCopyMessage)
Expand All @@ -153,7 +153,7 @@ export const NoteMenuBar = () => {
<nav>
<LastSyncedNotification datetime={lastSynced} pending={pendingSync} syncing={syncing} />
<button
className="note-menu-bar-button"
className="note-menu-bar-button reload"
onClick={syncNotesHandler}
data-testid={TestID.TOPBAR_ACTION_SYNC_NOTES}
>
Expand All @@ -164,12 +164,12 @@ export const NoteMenuBar = () => {
)}
<span className="sr-only">Sync notes</span>
</button>
<button className="note-menu-bar-button" onClick={toggleDarkThemeHandler}>
<button className="note-menu-bar-button moon" onClick={toggleDarkThemeHandler}>
{darkTheme ? <Sun aria-hidden="true" size={18} /> : <Moon aria-hidden="true" size={18} />}
<span className="sr-only">Themes</span>
</button>

<button className="note-menu-bar-button" onClick={settingsHandler}>
<button className="note-menu-bar-button setting" onClick={settingsHandler}>
<Settings aria-hidden="true" size={18} />
<span className="sr-only">Settings</span>
</button>
Expand Down
33 changes: 33 additions & 0 deletions src/client/styles/_note-menu-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,39 @@
&.uuid {
display: flex;
align-items: center;
&:hover {
color: $note-icon-color;
}
}
&.star {
&:hover {
color: $yellow;
}
}
&.eye {
&:hover {
color: $primary;
}
}
&.download {
&:hover {
color: $download-icon-color;
}
}
&.moon {
&:hover {
color: $moon-icon;
}
}
&.reload {
&:hover {
color: $reload-icon-color;
}
}
&.setting {
&:hover {
color: lighten($primary, 10%);
}
}
}

Expand Down
5 changes: 5 additions & 0 deletions src/client/styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,8 @@ $attribute: #ffd479;
$class: #e1a6f2;
$tag: #6ab0f3;
$error: #f2777a;
$yellow: #ffd700;
$download-icon-color: #2cc56d;
$note-icon-color: #08475e;
$reload-icon-color: #f17017;
$moon-icon: #ebd28b;