feat: upgrade to new workspace (workspace — requires tweaks) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
reviewed
Jan 13, 2025
| /// Helper function to compute deterministic hashes for the WSTS processes. | ||
| /// Note: for signing, the "call_id" should be the call_id of the preceeding | ||
| /// keygen job | ||
| pub fn compute_deterministic_hashes( | ||
| pub fn compute_execution_hashes( |
There was a problem hiding this comment.
Remove this fn and just use gadget-crypto-hasing and just hash these values in place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the first external application of the workspace, the workspace will need the following enhancements:
networkingunder thegadget-context-derivecrate; then enable thenetworkingfeature undergadget-networkingsimultaneously#[cfg(feature = "networking")]NetworkDeliveryWrapperblueprint_test_utilsfor testing