-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brown bag bump to 1.3.3 #1484
Brown bag bump to 1.3.3 #1484
Conversation
WalkthroughThis pull request primarily focuses on updating the version of the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (12)
- .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
- docs/conf.py (1 hunks)
- docs/installation.md (1 hunks)
- docs/notebooks/Data_structures.ipynb (1 hunks)
- docs/notebooks/Interactive_and_realtime_inference.ipynb (1 hunks)
- docs/notebooks/Interactive_and_resumable_training.ipynb (1 hunks)
- docs/notebooks/Model_evaluation.ipynb (1 hunks)
- docs/notebooks/Post_inference_tracking.ipynb (1 hunks)
- docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1 hunks)
- docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1 hunks)
- pypi_requirements.txt (1 hunks)
- sleap/version.py (1 hunks)
Files skipped from review due to trivial changes (9)
- .github/ISSUE_TEMPLATE/bug_report.md
- docs/conf.py
- docs/installation.md
- docs/notebooks/Data_structures.ipynb
- docs/notebooks/Interactive_and_realtime_inference.ipynb
- docs/notebooks/Model_evaluation.ipynb
- docs/notebooks/Post_inference_tracking.ipynb
- pypi_requirements.txt
- sleap/version.py
Additional comments (Suppressed): 3
docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1)
- 62-66: Ensure that the new version of
sleap
(1.3.3) is compatible with the rest of the codebase and doesn't introduce any breaking changes.docs/notebooks/Interactive_and_resumable_training.ipynb (1)
- 65-65: The version of
sleap
package has been updated from 1.3.1 to 1.3.3. Ensure that this change is compatible with the rest of the codebase and doesn't introduce any breaking changes.- "!pip install -qqq sleap==1.3.1\n", + "!pip install -qqq sleap[pypi]>=1.3.3\n",docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1)
- 59-62: The SLEAP version has been updated from 1.3.1 to 1.3.3. Ensure that the new version doesn't introduce any breaking changes or incompatibilities with the current notebook.
Codecov Report
@@ Coverage Diff @@
## develop #1484 +/- ##
===========================================
- Coverage 73.12% 73.11% -0.02%
===========================================
Files 134 134
Lines 23956 23963 +7
===========================================
+ Hits 17519 17521 +2
- Misses 6437 6442 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (7)
- docs/notebooks/Data_structures.ipynb (1 hunks)
- docs/notebooks/Interactive_and_realtime_inference.ipynb (1 hunks)
- docs/notebooks/Interactive_and_resumable_training.ipynb (1 hunks)
- docs/notebooks/Model_evaluation.ipynb (1 hunks)
- docs/notebooks/Post_inference_tracking.ipynb (1 hunks)
- docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1 hunks)
- docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/notebooks/Training_and_inference_using_Google_Drive.ipynb
Additional comments (Suppressed): 6
docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1)
- 64-65: Ensure that the new version of
sleap
(1.3.3 or higher) does not introduce any breaking changes or incompatibilities with the current codebase.docs/notebooks/Interactive_and_realtime_inference.ipynb (1)
- 63-63: The version of
sleap
has been updated from1.3.1
to1.3.3
. Ensure that this new version is compatible with the rest of the codebase and does not introduce any breaking changes.docs/notebooks/Interactive_and_resumable_training.ipynb (1)
- 65-65: The version of
sleap
package has been updated from1.3.1
to>=1.3.3
. Ensure that the new version doesn't introduce any breaking changes or incompatibilities with the current codebase.docs/notebooks/Data_structures.ipynb (1)
- 59-59: The version constraint for the
sleap
package has been updated from a fixed version to>=1.3.3
. This means any version equal to or greater than 1.3.3 is acceptable. Ensure that this change is intentional and that there are no compatibility issues with versions higher than 1.3.3.docs/notebooks/Post_inference_tracking.ipynb (1)
- 64-64: The version constraint for the
sleap
package has been changed from a fixed version to>=1.3.3
. This means any version equal to or greater than 1.3.3 is acceptable. Ensure that this change does not introduce compatibility issues with other parts of the codebase that depend on specific features or behaviors of thesleap
package.docs/notebooks/Model_evaluation.ipynb (1)
- 43-43: The version constraint for the
sleap
package has been updated from a fixed version "1.3.1" to a more flexible one ">=1.3.3". This allows for any version equal to or greater than 1.3.3 to be installed, which can include future updates and bug fixes. However, ensure that this does not introduce any breaking changes with newer versions of the package.- "!pip install -qqq sleap==1.3.1\n", + "!pip install -qqq \"sleap[pypi]>=1.3.3\"\n",
Description
This is a brown-bag release of 1.3.3 after testing the wheel in colab https://colab.research.google.com/drive/1L0cW_uG-Qv3qy30jTXBB8fsuiXzeQTAq?usp=sharing
Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
pypi_requirements.txt
to ensure compatibility with the latest versions of other dependencies.docs/installation.md
to reflect the new SLEAP version.