Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brown bag bump to 1.3.3 #1484

Merged
merged 16 commits into from
Sep 15, 2023
Merged

Brown bag bump to 1.3.3 #1484

merged 16 commits into from
Sep 15, 2023

Conversation

roomrys
Copy link
Collaborator

@roomrys roomrys commented Sep 11, 2023

Description

This is a brown-bag release of 1.3.3 after testing the wheel in colab https://colab.research.google.com/drive/1L0cW_uG-Qv3qy30jTXBB8fsuiXzeQTAq?usp=sharing

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

Summary by CodeRabbit

  • New Feature: Upgraded SLEAP to version 1.3.3 across all documentation and notebooks, ensuring users have access to the latest features and bug fixes.
  • Bug Fix: Updated TensorFlow version constraints in pypi_requirements.txt to ensure compatibility with the latest versions of other dependencies.
  • Documentation: Revised installation instructions in docs/installation.md to reflect the new SLEAP version.
  • Chore: Adjusted the pip installation commands in various Jupyter notebooks to use the updated SLEAP version.

@roomrys roomrys changed the title Brown bag bump to 1.3.3a0 Brown bag bump to 1.3.3 Sep 11, 2023
@roomrys roomrys marked this pull request as ready for review September 11, 2023 21:53
@coderabbitai
Copy link

coderabbitai bot commented Sep 11, 2023

Walkthrough

This pull request primarily focuses on updating the version of the sleap package across various files from older versions to 1.3.3 or >=1.3.3. It also includes changes in TensorFlow dependencies for different platforms in the requirements file.

Changes

File(s) Summary
.github/ISSUE_TEMPLATE/bug_report.md, docs/conf.py, sleap/version.py Updated the software version number from 1.3.2 to 1.3.3.
docs/installation.md, pypi_requirements.txt Updated the sleap package version and TensorFlow dependencies for different platforms.
docs/notebooks/*.ipynb Changed the pip installation command for the sleap package to ensure at least version 1.3.3 is installed.

🐇💻

"In the land of code, where the shadows lie,

A rabbit hops, under the cloudless sky.

With each leap forward, a version anew,

Bugs squashed, features polished, for me and you.

So raise your carrots, high and free,

Here's to sleap, version 1.3.3!" 🥕🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between e4fca4f and 42ab441 commits.
Files selected for processing (12)
  • .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
  • docs/conf.py (1 hunks)
  • docs/installation.md (1 hunks)
  • docs/notebooks/Data_structures.ipynb (1 hunks)
  • docs/notebooks/Interactive_and_realtime_inference.ipynb (1 hunks)
  • docs/notebooks/Interactive_and_resumable_training.ipynb (1 hunks)
  • docs/notebooks/Model_evaluation.ipynb (1 hunks)
  • docs/notebooks/Post_inference_tracking.ipynb (1 hunks)
  • docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1 hunks)
  • docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1 hunks)
  • pypi_requirements.txt (1 hunks)
  • sleap/version.py (1 hunks)
Files skipped from review due to trivial changes (9)
  • .github/ISSUE_TEMPLATE/bug_report.md
  • docs/conf.py
  • docs/installation.md
  • docs/notebooks/Data_structures.ipynb
  • docs/notebooks/Interactive_and_realtime_inference.ipynb
  • docs/notebooks/Model_evaluation.ipynb
  • docs/notebooks/Post_inference_tracking.ipynb
  • pypi_requirements.txt
  • sleap/version.py
Additional comments (Suppressed): 3
docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1)
  • 62-66: Ensure that the new version of sleap (1.3.3) is compatible with the rest of the codebase and doesn't introduce any breaking changes.
docs/notebooks/Interactive_and_resumable_training.ipynb (1)
  • 65-65: The version of sleap package has been updated from 1.3.1 to 1.3.3. Ensure that this change is compatible with the rest of the codebase and doesn't introduce any breaking changes.
- "!pip install -qqq sleap==1.3.1\n",
+ "!pip install -qqq sleap[pypi]>=1.3.3\n",
docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1)
  • 59-62: The SLEAP version has been updated from 1.3.1 to 1.3.3. Ensure that the new version doesn't introduce any breaking changes or incompatibilities with the current notebook.

@roomrys roomrys changed the base branch from develop to liezl/hotfix-1.3.2 September 11, 2023 22:05
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1484 (8a0a6af) into develop (734283a) will decrease coverage by 0.02%.
Report is 11 commits behind head on develop.
The diff coverage is 58.33%.

❗ Current head 8a0a6af differs from pull request most recent head 30c93b3. Consider uploading reports for the commit 30c93b3 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1484      +/-   ##
===========================================
- Coverage    73.12%   73.11%   -0.02%     
===========================================
  Files          134      134              
  Lines        23956    23963       +7     
===========================================
+ Hits         17519    17521       +2     
- Misses        6437     6442       +5     
Files Changed Coverage Δ
sleap/gui/overlays/base.py 57.64% <54.54%> (-1.33%) ⬇️
sleap/version.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys roomrys requested a review from talmo September 11, 2023 22:33
@roomrys roomrys mentioned this pull request Sep 12, 2023
4 tasks
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 42ab441 and ae26cdb commits.
Files selected for processing (1)
  • docs/installation.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/installation.md

Base automatically changed from liezl/hotfix-1.3.2 to develop September 14, 2023 21:24
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between ae26cdb and 8a0a6af commits.
Files selected for processing (1)
  • docs/installation.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/installation.md

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 8a0a6af and 30c93b3 commits.
Files selected for processing (7)
  • docs/notebooks/Data_structures.ipynb (1 hunks)
  • docs/notebooks/Interactive_and_realtime_inference.ipynb (1 hunks)
  • docs/notebooks/Interactive_and_resumable_training.ipynb (1 hunks)
  • docs/notebooks/Model_evaluation.ipynb (1 hunks)
  • docs/notebooks/Post_inference_tracking.ipynb (1 hunks)
  • docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1 hunks)
  • docs/notebooks/Training_and_inference_using_Google_Drive.ipynb (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/notebooks/Training_and_inference_using_Google_Drive.ipynb
Additional comments (Suppressed): 6
docs/notebooks/Training_and_inference_on_an_example_dataset.ipynb (1)
  • 64-65: Ensure that the new version of sleap (1.3.3 or higher) does not introduce any breaking changes or incompatibilities with the current codebase.
docs/notebooks/Interactive_and_realtime_inference.ipynb (1)
  • 63-63: The version of sleap has been updated from 1.3.1 to 1.3.3. Ensure that this new version is compatible with the rest of the codebase and does not introduce any breaking changes.
docs/notebooks/Interactive_and_resumable_training.ipynb (1)
  • 65-65: The version of sleap package has been updated from 1.3.1 to >=1.3.3. Ensure that the new version doesn't introduce any breaking changes or incompatibilities with the current codebase.
docs/notebooks/Data_structures.ipynb (1)
  • 59-59: The version constraint for the sleap package has been updated from a fixed version to >=1.3.3. This means any version equal to or greater than 1.3.3 is acceptable. Ensure that this change is intentional and that there are no compatibility issues with versions higher than 1.3.3.
docs/notebooks/Post_inference_tracking.ipynb (1)
  • 64-64: The version constraint for the sleap package has been changed from a fixed version to >=1.3.3. This means any version equal to or greater than 1.3.3 is acceptable. Ensure that this change does not introduce compatibility issues with other parts of the codebase that depend on specific features or behaviors of the sleap package.
docs/notebooks/Model_evaluation.ipynb (1)
  • 43-43: The version constraint for the sleap package has been updated from a fixed version "1.3.1" to a more flexible one ">=1.3.3". This allows for any version equal to or greater than 1.3.3 to be installed, which can include future updates and bug fixes. However, ensure that this does not introduce any breaking changes with newer versions of the package.
- "!pip install -qqq sleap==1.3.1\n",
+ "!pip install -qqq \"sleap[pypi]>=1.3.3\"\n",

@roomrys roomrys merged commit a2092f0 into develop Sep 15, 2023
@roomrys roomrys deleted the liezl/bump-1.3.3 branch September 15, 2023 22:55
roomrys added a commit that referenced this pull request Sep 15, 2023
* Do not try to remove item if already deleted (#1498)

* Set `LD_LIBRARY_PATH` on `mamba activate` (#1496)

* Add version restrictions to tensorflow for pypi (#1485)

* Remove `imageio` pin (#1501)

* Reset LD_LIBRARY_PATH on deactivate (#1502)

* Brown bag bump to 1.3.3 (#1484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant