Skip to content

Commit

Permalink
fix(language-service): allow native esm to import package (#1122)
Browse files Browse the repository at this point in the history
with this patch, `@tailwindcss/language-service` can be imported/used in
Node.js in native esm mode.

adjusted "semver" imports to include an extension, as that package has
no "exports".

also upgrade semver to latest stable (7.7.1)

---------

Co-authored-by: Jordan Pittman <jordan@cryptica.me>
  • Loading branch information
AviVahl and thecrypticace authored Feb 4, 2025
1 parent 3277fa3 commit bdd9605
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 34 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"esbuild": "^0.24.0",
"minimist": "^1.2.8",
"prettier": "^3.2.5",
"semver": "^7.5.4"
"semver": "^7.7.1"
},
"prettier": {
"semi": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/tailwindcss-language-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"postcss": "8.4.31",
"postcss-selector-parser": "6.0.2",
"postcss-value-parser": "4.2.0",
"semver": "7.5.2",
"semver": "7.7.1",
"sift-string": "0.0.2",
"stringify-object": "3.3.0",
"tmp-cache": "1.1.0",
Expand Down
6 changes: 4 additions & 2 deletions packages/tailwindcss-language-service/src/util/semver.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
import semverGte from 'semver/functions/gte'
import semverLte from 'semver/functions/lte'
import semverGte from 'semver/functions/gte.js'
import semverLte from 'semver/functions/lte.js'

export function gte(v1: string, v2: string): boolean {
if (v1.startsWith('0.0.0-insiders')) {
return true
}

return semverGte(v1, v2)
}

export function lte(v1: string, v2: string): boolean {
if (v1.startsWith('0.0.0-insiders')) {
return false
}

return semverLte(v1, v2)
}
49 changes: 19 additions & 30 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bdd9605

Please sign in to comment.