Skip to content

Commit

Permalink
Fix suggestion of utilities with slashes in them in v4 (#1182)
Browse files Browse the repository at this point in the history
All utilities implicitly have at least `modifiers: []` in the class list
when no modifiers are present. We should only change the completion list
when there are actually modifiers to show in case an existing utility
with a slash in it (e.g. `w-1/2`) is “close” to what the user has typed.

This is the other half to fix #1178 b/c while the completions show up
but as soon as you type `/` they disappear which is an awful experience.
  • Loading branch information
thecrypticace authored Feb 10, 2025
1 parent cccab4d commit ae2c6d9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ export function completionsFromClassList(
let beforeSlash = partialClassName.split('/').slice(0, -1).join('/')

let baseClassName = beforeSlash.slice(offset)
modifiers = state.classList.find((cls) => Array.isArray(cls) && cls[0] === baseClassName)?.[1]
?.modifiers
modifiers =
state.classList.find((cls) => Array.isArray(cls) && cls[0] === baseClassName)?.[1]
?.modifiers ?? []

if (modifiers) {
if (modifiers.length > 0) {
return withDefaults(
{
isIncomplete: false,
Expand Down
1 change: 1 addition & 0 deletions packages/vscode-tailwindcss/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Add details about theme options when hovering ([#1176](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1176))
- Fix parsing of `@custom-variant` shorthand in Tailwind CSS language mode ([#1183](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1183))
- Make sure custom regexes apply in Vue `<script>` blocks ([#1177](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1177))
- Fix suggestion of utilities with slashes in them in v4 ([#1182](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1182))

## 0.14.3

Expand Down

0 comments on commit ae2c6d9

Please sign in to comment.