Skip to content

feat(ci): do not download the published npm version of Tact in CI #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(ci): do not download the published npm version of Tact in CI #2740

wants to merge 14 commits into from

Conversation

novusnota
Copy link
Member

Issue

Closes #1810.

@novusnota novusnota added this to the v1.6.6 milestone Apr 11, 2025
@novusnota novusnota requested a review from a team as a code owner April 11, 2025 15:31
@novusnota
Copy link
Member Author

novusnota commented Apr 11, 2025 •
edited
Loading

fixin'
UPD: done

@novusnota novusnota marked this pull request as draft April 11, 2025 16:25
@novusnota novusnota marked this pull request as ready for review April 11, 2025 19:39
@novusnota
Copy link
Member Author

image

Windows CI ran long enough to encounter the storage fees.

@anton-trunov anton-trunov requested a review from i582 April 12, 2025 14:46
@anton-trunov
Copy link
Member

I tried, but I have no idea what's going on here. We need vibe reviewing from @copilot or @i582

@novusnota
Copy link
Member Author

novusnota commented Apr 15, 2025 •
edited
Loading

We can also unite the main tact job with its Windows counterpart in the same manner as I did unite workflows of Node.js package managers in this PR.

At the discretion of @xpyctumo

@novusnota novusnota requested a review from verytactical April 16, 2025 11:03
@novusnota novusnota modified the milestones: v1.6.6, Infra: 2025-04 Apr 16, 2025
@xpyctumo
Copy link
Contributor

We can also unite the main tact job with its Windows counterpart in the same manner as I did unite workflows of Node.js package managers in this PR.

Yes, please. Use it from my PR. I fixed it here.

In my PR it would be unnecessary right now

@novusnota novusnota requested a review from xpyctumo May 5, 2025 12:53
@novusnota novusnota removed this from the Infra: 2025-04 milestone May 5, 2025
@novusnota novusnota added this to the Infra: 2025-05 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i582 i582 Awaiting requested review from i582

@verytactical verytactical Awaiting requested review from verytactical

@xpyctumo xpyctumo Awaiting requested review from xpyctumo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Infra: 2025-05
Development

Successfully merging this pull request may close these issues.

Don't download the published version of Tact in CI
3 participants
@novusnota @anton-trunov @xpyctumo