Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protogen: support workbook alias in metasheet @TABLEAU #89

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

wenchy
Copy link
Member

@wenchy wenchy commented Mar 11, 2024

@wenchy wenchy requested a review from Kybxd March 11, 2024 15:21
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.07%. Comparing base (2e43cc5) to head (abc638b).

Files Patch % Lines
internal/protogen/util.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   62.00%   62.07%   +0.06%     
==========================================
  Files          37       37              
  Lines        5704     5717      +13     
==========================================
+ Hits         3537     3549      +12     
  Misses       1791     1791              
- Partials      376      377       +1     
Flag Coverage Δ
unittests 62.07% <78.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kybxd Kybxd merged commit 396f71c into master Mar 12, 2024
14 checks passed
@wenchy wenchy mentioned this pull request Mar 12, 2024
20 tasks
@wenchy wenchy deleted the workbook-alias branch March 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protogen: support workbook alias in metasheet @TABLEAU
2 participants