Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed this.reset() from componentWillUnmount #20

Closed
wants to merge 1 commit into from
Closed

Removed this.reset() from componentWillUnmount #20

wants to merge 1 commit into from

Conversation

smacpherson64
Copy link

In efforts to resolve the error of #19, removing the this.reset() call in componentWillUnmount.

@smacpherson64
Copy link
Author

This is affecting Chrome, Edge, and IE11.

Firefox appears to be working as desired.

When trying this fix, Edge no longer resets the visual.

@smacpherson64 smacpherson64 deleted the patch-1 branch July 17, 2018 18:47
@nukisman
Copy link

nukisman commented Aug 6, 2018

Hi there!
Why this fix is not published yet?

@smacpherson64
Copy link
Author

smacpherson64 commented Aug 6, 2018

Hey @nukisman, This solution unfortunately caused unwanted side effects in Edge and only partially solved the issue in other browsers. When removing this.reset() Edge no longer reset's the visual.

@nukisman
Copy link

nukisman commented Aug 6, 2018

@smacpherson64
Ooo, sadly. And what is a solution for this issue?

@smacpherson64
Copy link
Author

smacpherson64 commented Aug 6, 2018

Hey @nukisman, That is a good question! For the project I was on, I ended up creating a component that was a bit more hard coded to the grecaptcha api. I would prefer to use this component, but I ran out of time while debugging and had to switch. The error is coming from inside of the actual recaptcha script (not this component) when the element is removed.

At first investigation, I thought this was occurring inside of this.reset() however after implementing the fix and testing further I found it was not the core reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants