Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Update to JDK21 #34

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Breaking Change: Update to JDK21 #34

merged 2 commits into from
Oct 24, 2024

Conversation

joaquimvila
Copy link
Contributor

PR Details

Upgrade this library to compile for JDK21. As this is a breaking change, the major version should be updated to 2.0.0

Motivation and Context

JDK21 is the latest LTS version of Java. This library is updated to support it.

Implementation

Update Maven configuration of the library to compile for JDK21.

Related Feature

#33

How Has This Been Tested

  • Library test suite has been executed successfully

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New release version
  • Breaking change (fix or feature that would cause existing functionality to change)

Attachments

None relevant.

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • There are component tests for new/changed code (or a good explanation why this was not possible) and all of them passed. I have also added tests to cover my changes
  • All CI builders have indicated success (Give them the needed time to notice the pull request)
  • The Pull request title has the type of change ended with a slash (bugfix/feature/...), Jira issue numbers separated by spaces (if any), a space, and then a short, but descriptive summary
  • Commit messages are well formed: A note about Git commit messages
  • New public packages, classes, and methods are documented. (Strongly consider documenting private classes and methods)
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in pom.xml following Semantic Versioning

Copy link
Contributor

@gmartinez3werfen gmartinez3werfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@davidberruezo davidberruezo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this change

@joaquimvila joaquimvila merged commit f65fe32 into master Oct 24, 2024
1 check passed
@joaquimvila joaquimvila deleted the feature/33 branch October 24, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants