Use upstream SoftFloat and unify build system #557
+352
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run #ba12d7Actionable Suggestions - 1
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
jserv
commented
Feb 7, 2025
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: b41f6fa | Previous: 8bcf084 | Ratio |
|---|---|---|---|
Dhrystone |
1321 Average DMIPS over 10 runs |
1318 Average DMIPS over 10 runs |
1.00 |
Coremark |
946.94 Average iterations/sec over 10 runs |
948.979 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
jserv
force-pushed
the
modular-softfloat
branch
from
a78b90b to
2b375ea
Compare
Code Review Agent Run #e1b2a2Actionable Suggestions - 0Review Details
AI Code Review powered by |
jserv
force-pushed
the
modular-softfloat
branch
from
2b375ea to
d3275eb
Compare
Code Review Agent Run #990067Actionable Suggestions - 0Review Details
AI Code Review powered by |
jserv
force-pushed
the
modular-softfloat
branch
from
d3275eb to
8bcf084
Compare
Code Review Agent Run #81a04aActionable Suggestions - 1
Review Details
AI Code Review powered by |
Replace custom Berkeley SoftFloat 3 package in 'src/softfloat' with the upstream one. It streamlines build system onfiguration for consistency.
jserv
force-pushed
the
modular-softfloat
branch
from
8bcf084 to
b41f6fa
Compare
Code Review Agent Run #917e75Actionable Suggestions - 1
Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom Berkeley SoftFloat 3 package in 'src/softfloat' with the upstream one. It streamlines build system onfiguration for consistency.
Summary by Bito
This PR integrates the upstream Berkeley SoftFloat 3 package, replacing the custom version. The changes focus on build system improvements through a new mk/softfloat.mk file, updated submodule configuration, and streamlined header paths. The modifications enhance build organization and dependency management for SoftFloat-related components.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2