Skip to content

Commit

Permalink
Ensure 'helm repo add' is also not pollute on helmfile template
Browse files Browse the repository at this point in the history
When having multiple helmfiles in one helmfile.d folder and multiple of
them having repositories defined, the errors mention in helmfile#1749 still
existed.

Fixes helmfile#1749 (again)
  • Loading branch information
baurmatt committed Jan 22, 2025
1 parent 4e58bd4 commit c030962
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions pkg/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ func (a *App) Template(c TemplateConfigProvider) error {
// Live output should never be enabled for the "template" subcommand to avoid breaking `helmfile template | kubectl apply -f -`
run.helm.SetEnableLiveOutput(false)

// Reset helm extra args to not pollute BuildDeps() and AddRepo() on subsequent helmfiles
// https://github.com/helmfile/helmfile/issues/1749
run.helm.SetExtraArgs()

prepErr := run.withPreparedCharts("template", state.ChartPrepareOptions{
SkipRepos: c.SkipRefresh() || c.SkipDeps(),
SkipRefresh: c.SkipRefresh(),
Expand Down
4 changes: 0 additions & 4 deletions pkg/state/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -1449,10 +1449,6 @@ func (st *HelmState) runHelmDepBuilds(helm helmexec.Interface, concurrency int,
//
// See https://github.com/roboll/helmfile/issues/1521

// Reset helm extra args to not pollute BuildDeps() on subsequent helmfiles
// https://github.com/helmfile/helmfile/issues/1749
helm.SetExtraArgs()

for _, r := range builds {
buildDepsFlags := getBuildDepsFlags(r)
if err := helm.BuildDeps(r.releaseName, r.chartPath, buildDepsFlags...); err != nil {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
repositories:
- name: bitnami
url: https://charts.bitnami.com/bitnami

releases:
- name: test1
chart: ../../../../charts/raw
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
repositories:
- name: prometheus-community
url: https://prometheus-community.github.io/helm-charts

releases:
- name: test2
chart: ../../../../charts/raw
Expand Down

0 comments on commit c030962

Please sign in to comment.