Fix to allow assigning react runtime to types

Related-to: mdx-js/mdx#2465.
syntax-tree · Oct 14, 2024 · e093df5 · e093df5
1 parent b0e5702
commit e093df5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/types.d.ts b/lib/types.d.ts
@@ -141,7 +141,9 @@ type FunctionComponent<ComponentProps> = (
  * Create a production element.
  */
 export type Jsx = (
-  type: unknown,
+  // `any` because runtimes often have complex framework-specific types here.
+  // type-coverage:ignore-next-line
+  type: any,
   props: Props,
   key?: string | undefined
 ) => JSX.Element
@@ -150,7 +152,9 @@ export type Jsx = (
  * Create a development element.
  */
 export type JsxDev = (
-  type: unknown,
+  // `any` because runtimes often have complex framework-specific types here.
+  // type-coverage:ignore-next-line
+  type: any,
   props: Props,
   key: string | undefined,
   isStaticChildren: boolean,

diff --git a/test/index.js b/test/index.js
@@ -257,6 +257,9 @@ test('properties', async function (t) {
           }),
           {
             ...production,
+            /**
+             * @param {unknown} type
+             */
             jsx(type, props) {
               foundProps = props
               return production.jsx(type, {})
@@ -671,6 +674,9 @@ test('react specific: `align` to `style`', async function (t) {
         renderToStaticMarkup(
           toJsxRuntime(h('td', {align: 'center'}), {
             ...production,
+            /**
+             * @param {unknown} type
+             */
             jsx(type, props) {
               foundProps = props
               return production.jsx(type, {})
@@ -695,6 +701,9 @@ test('react specific: `align` to `style`', async function (t) {
         renderToStaticMarkup(
           toJsxRuntime(h('td', {align: 'center'}), {
             ...production,
+            /**
+             * @param {unknown} type
+             */
             jsx(type, props) {
               foundProps = props
               return production.jsx(type, {})